Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zernike.py pulling non-existant dependancies emath #98

Open
CJonesANU opened this issue Sep 5, 2024 · 1 comment · May be fixed by #99
Open

Zernike.py pulling non-existant dependancies emath #98

CJonesANU opened this issue Sep 5, 2024 · 1 comment · May be fixed by #99
Assignees

Comments

@CJonesANU
Copy link

Problem

Importing aotools in python12, on windows fails.

Cause

Within aotools\functions\zernike.py , zernikeRadialFunc calls numpy.emath.factorial which I believe was depreciated a while back.

Solution

Temporary Solution

I was able to monkey patch it in my loca environment by importing math and swapping references to numpy.math.factorial to math.factorial

Long term solution

I was going to try issue a pull request, but issues with verssioner.py are preventing me from installing it locally. (I think this is a different issue lol)

If you could make the changes that would be an easy fix to get windows users up and running.

Cheers
Cam

@matthewtownson
Copy link
Member

Thanks for sorting this, I haven't tested aotools with the latest numpy or Python version properly. It's something I'm hoping to do this week.

@matthewtownson matthewtownson self-assigned this Sep 16, 2024
@matthewtownson matthewtownson linked a pull request Sep 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants