fix eslint core rules

Author: IvanGoncharov

.eslintrc.yml

@@ -19,10 +19,6 @@ rules:
   'import/no-extraneous-dependencies':
     [error, { devDependencies: ['**/*.config.{js,ts}', 'tests/**'] }]
 
-  # FIXME: remove below rules
-  'no-var': off
-  'prefer-const': off
-
 overrides:
   - files: '**/*.js'
     env:
@@ -45,9 +41,6 @@ overrides:
         [error, index-signature]
 
       # FIXME: remove below rules
-      'no-empty': off
-      'no-var': off
-      'prefer-const': off
       'react/jsx-no-target-blank': off
       'import/no-duplicates': off
       'import/no-extraneous-dependencies': off

src/editor/custom.d.ts

@@ -1,4 +1,4 @@
 declare module '*.css' {
-  var content: any;
+  const content: any;
   export = content;
 }

src/editor/index.tsx

@@ -126,7 +126,7 @@ class FakeEditor extends React.Component<any, FakeEditorState> {
   }
 
   saveUserSDL = () => {
-    let { value, hasUnsavedChanges } = this.state;
+    const { value, hasUnsavedChanges } = this.state;
     if (!hasUnsavedChanges) return;
 
     if (!this.updateSDL(value)) return;
@@ -161,7 +161,9 @@ class FakeEditor extends React.Component<any, FakeEditorState> {
     let unsavedSchema = null as GraphQLSchema | null;
     try {
       unsavedSchema = this.buildSchema(val, { skipValidation: true });
-    } catch (_) {}
+    } catch (_) {
+      // FIXME
+    }
 
     this.setState((prevState) => ({
       ...prevState,
@@ -172,7 +174,7 @@ class FakeEditor extends React.Component<any, FakeEditorState> {
   };
 
   render() {
-    let { value, activeTab, schema, hasUnsavedChanges, unsavedSchema } = this.state;
+    const { value, activeTab, schema, hasUnsavedChanges, unsavedSchema } = this.state;
     if (value == null || schema == null) {
       return <div className="faker-editor-container">Loading...</div>;
     }

src/fake.ts

@@ -196,7 +196,7 @@ const fakeFunctions = {
 };
 
 Object.keys(fakeFunctions).forEach((key) => {
-  var value = fakeFunctions[key];
+  const value = fakeFunctions[key];
   if (typeof fakeFunctions[key] === 'function')
     fakeFunctions[key] = { args: [], func: value };
 });

src/index.ts

@@ -193,7 +193,7 @@ function prettyPrintValidationErrors(validationErrors: ValidationErrors) {
   );
 
   for (const error of subErrors) {
-    let [message, ...otherLines] = error.toString().split('\n');
+    const [message, ...otherLines] = error.toString().split('\n');
     log([chalk.yellow(message), ...otherLines].join('\n') + '\n\n');
   }
 }