Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to CMake changes to enable library sub-builds #571

Merged
merged 5 commits into from
Nov 20, 2024

Commits on Nov 18, 2024

  1. Update script arguments and set external lit

    Two scripts arguments were renamed during review, but the cmake
    steps calling the script weren't updated.
    
    Additionally the our downstream test targets such as
    check-package-llvm-toolchain target require the path to an external
    llvm-lit in order to run the tests.
    dcandler committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d488702 View commit details
    Browse the repository at this point in the history
  2. Fix enabling of exceptions and RTTI

    The variables to enable exceptions and RTTI are now cached and the names
    are capitalized, but CMake arguments needed updating to reflect this.
    dcandler committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    3871ed2 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Reinstate PREBUILT_TARGET_LIBRARIES option

    The PREBUILT_TARGET_LIBRARIES option is meant to disable the building of
    all libraries, on the assumption that pre-built libraries will be
    copied from another location. The functionality was accidentally removed,
    but has now been returned.
    dcandler committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    28fd984 View commit details
    Browse the repository at this point in the history
  2. Correctly pass down list of variants to enable

    CMake automatically expands a string containing semi-colons to a
    list, but ExternalProject argument must also be a semi-colon
    separated list. To get around this, convert the string to a comma
    separated list, since the LIST_SEPARATOR option will reinterpret
    this as a semi-colon list.
    dcandler committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6b98d48 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Disable FVP testing by default

    Previously, FVP testing was skipped if a FVP install was not
    available. However, this now throws a configuration error if testing
    relies on FVPs. But if you specifically want to test with FVPs, it is
    desirable to have the configuration error warn you with an if the
    install cannot be found.
    
    To resolve this, an additional option has been added to explicitly
    enable FVP testing, defaulting to OFF. This will override any
    settings from the variant JSON, so that the default case remains
    skipping FVP testing.
    dcandler committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b9254e2 View commit details
    Browse the repository at this point in the history