Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIC tests seems to rely on MSI-X feature being enabled for v3 + ITS #338

Open
camwilde77 opened this issue Sep 18, 2024 · 4 comments
Open

Comments

@camwilde77
Copy link

From my understanding, the GIC (GIV v3 + ITS) tests can be set up as MSI or MSI-X. v3 + ITS can have full MSI-X support at the RP, but doesn't have to use it. You could also have an endpoint that supports it (or not). As far as I can tell, the BSA code expects that MSI-X is always supported for GIC v3 + ITS, but a system could still decide to not do that. Shouldn't these tests default to MSI when the RP compatibility register shows MSI-X as not enabled? This seems to affect tests 904, 911. 912, and 913.

@sunnywang-arm
Copy link
Contributor

I agree with the comment here. BSA PCIe exerciser tests should check both MSI and MSI-X capable endpoint devices rather than only MSI-X capable endpoint devices.

@gowthamsiddarthd and @chetan-rathore Can we get ACS team to fix the issue?

@rajatgoyal47
Copy link
Collaborator

Hi,

Thank you for reporting this.
We are working on fixing and adding support for MSI in the tests.

Regards,
ACS Team

@cdwilde
Copy link

cdwilde commented Jan 24, 2025

Do we have a timeframe for this fix?

Sujana-M added a commit to Sujana-M/bsa-acs that referenced this issue Mar 5, 2025
- Fixes ARM-software#338
- Provided support for both MSI and MSI-X support
- If both are supported, MSI-X is taken precedence
  and that is enabled and verified.

Signed-off-by: Sujana M <[email protected]>
Sujana-M added a commit to Sujana-M/sbsa-acs that referenced this issue Mar 5, 2025
- Fixes ARM-software/bsa-acs#338
- Provided support for both MSI and MSI-X support
- If both are supported, MSI-X is taken precedence
  and that is enabled and verified.

Signed-off-by: Sujana M <[email protected]>
@Sujana-M
Copy link
Contributor

Sujana-M commented Mar 5, 2025

Hi @cdwilde @camwilde77 ,

The changes for MSI support are at commit
BSA:Sujana-M@004eca0
SBSA: Sujana-M/sbsa-acs@07c1aaa

The changes can be cherry-picked at your end. Please let us know if this provides the coverage.

Thanks,
ACS Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants