Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width and height of heliostats or facets #101

Open
MarleneBusch opened this issue Nov 28, 2024 · 1 comment
Open

Width and height of heliostats or facets #101

MarleneBusch opened this issue Nov 28, 2024 · 1 comment

Comments

@MarleneBusch
Copy link
Collaborator

Ambigous parameters
The heliostat_properties.json files from PAINT and the .binp files from Stral contain parameters for width and height of something. They are for example height": 2.559999942779541, "width": 3.2200000286102295. It seems like this is the height and width of an entire heliostat. However in the paint_to_surface_converter and in the stral_to_surface_converter those values are passed to every facet, making it seem like every facet has those width and height measurements.

To reproduce
Steps to reproduce the behavior:

  1. Open example scenario.h5 files and look at the facet parameters.
  2. Open heliostat_properties.json files and look at width and height.
  3. Compare

Expected behavior
Either the heliostat_properties.json files should have more specific names like facet_width and facet_height or the paint_to_surface_converter and the stral_to_surface_converter need to be corrected.

Additional context
Neither width or height is ever used in ARTIST, so as of now its irrelevant. If it will never be used in the future as well we could delete those parameters.

@MarleneBusch
Copy link
Collaborator Author

width and height have been removed from facet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant