You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ambigous parameters
The heliostat_properties.json files from PAINT and the .binp files from Stral contain parameters for width and height of something. They are for example height": 2.559999942779541, "width": 3.2200000286102295. It seems like this is the height and width of an entire heliostat. However in the paint_to_surface_converter and in the stral_to_surface_converter those values are passed to every facet, making it seem like every facet has those width and height measurements.
To reproduce
Steps to reproduce the behavior:
Open example scenario.h5 files and look at the facet parameters.
Open heliostat_properties.json files and look at width and height.
Compare
Expected behavior
Either the heliostat_properties.json files should have more specific names like facet_width and facet_height or the paint_to_surface_converter and the stral_to_surface_converter need to be corrected.
Additional context
Neither width or height is ever used in ARTIST, so as of now its irrelevant. If it will never be used in the future as well we could delete those parameters.
The text was updated successfully, but these errors were encountered:
Ambigous parameters
The
heliostat_properties.json
files fromPAINT
and the .binp files fromStral
contain parameters for width and height of something. They are for exampleheight": 2.559999942779541
,"width": 3.2200000286102295
. It seems like this is the height and width of an entire heliostat. However in thepaint_to_surface_converter
and in thestral_to_surface_converter
those values are passed to every facet, making it seem like every facet has those width and height measurements.To reproduce
Steps to reproduce the behavior:
Expected behavior
Either the
heliostat_properties.json
files should have more specific names like facet_width and facet_height or thepaint_to_surface_converter
and thestral_to_surface_converter
need to be corrected.Additional context
Neither
width
orheight
is ever used inARTIST
, so as of now its irrelevant. If it will never be used in the future as well we could delete those parameters.The text was updated successfully, but these errors were encountered: