Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyp3-nasa-disasters has No Static Analysis #158

Open
AndrewPlayer3 opened this issue Jan 2, 2025 · 2 comments
Open

hyp3-nasa-disasters has No Static Analysis #158

AndrewPlayer3 opened this issue Jan 2, 2025 · 2 comments
Labels
Jira Bug Create a Jira Bug for this issue

Comments

@AndrewPlayer3
Copy link

AndrewPlayer3 commented Jan 2, 2025

Jira: https://asfdaac.atlassian.net/browse/TOOL-3386

Note: The above link is accessible only to members of ASF.


There is no flake8 or ruff action. The ruff action should be added. However, we've decided not to add the ruff action at the same time as adding it to all the other repos, as this repo will require a large amount of manual cleanup.

@AndrewPlayer3 AndrewPlayer3 added the Jira Bug Create a Jira Bug for this issue label Jan 2, 2025
@jtherrmann
Copy link
Contributor

jtherrmann commented Jan 2, 2025

In particular, it looks like ruff generates lots of errors that need manual resolution even without any of the additional ruff extensions. Also, it looks like there's some Esri code in here, e.g. https://github.com/ASFHyP3/hyp3-nasa-disasters/blob/main/image_server/asf_services/scripts/imagery_service.py which we probably don't want to re-format.

Note that this repo also has no develop branch or release process beyond merging directly to main.

@jtherrmann
Copy link
Contributor

We should also add mypy if we add ruff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Bug Create a Jira Bug for this issue
Projects
None yet
Development

No branches or pull requests

2 participants