Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think I improved the readme and simplify the docker #860

Open
jrichardsz opened this issue Jun 6, 2020 · 4 comments
Open

I think I improved the readme and simplify the docker #860

jrichardsz opened this issue Jun 6, 2020 · 4 comments

Comments

@jrichardsz
Copy link

Today I tried to deploy askbot in heroku and/or openshift with no luck due to several problems:

  • There isn't a step by step readme with requirements and variables
  • Current Dockerfile in master does not allow me to parametrize if I have already a database, the database host , port , admin alias/mail, SECRET_KEY
  • If syncdb, migrate or collectstatic has an internal error, no log is displayed. So I stored them to /src/startup.log
  • I think readme.md is more more friendly than readme.rst
  • When I run the container, an error pointing me to use pytz<=2019.3 instead pytz<=2016.4
  • I added (and commented in .gitignore)init.py, manage.py , settings.py, urls.py to the root in order to start the server

Finally I was able to run a success docker container but with this changes. I didn't touch the core :
https://github.com/software-architect-tools/askbot/pull/1

How can I adapt to your standards this PR in order to point to your official repository?

Thanks

@evgenyfadeev
Copy link
Member

evgenyfadeev commented Jul 27, 2020

The issue is that I'm just in the progress of completing the askbot-setup script in the branch supporting python3.
Once this script is done it would perhaps make more sense to improve the docker deployment process.

I haven't read your changes yet, will do that some time tomorrow, thank you for being willing to contribute.

@jrichardsz
Copy link
Author

Thanks to you for your time.

@evgenyfadeev
Copy link
Member

Looks great, thank you for sharing your code, this will be implemented after the askbot-setup is done.

@martin-bts
Copy link

Your pull request is not available to me, so I cannot tell from which branch you tried to create a Docker image. The Askbot Python 3 branch, which is now this project's master branch used to contain Dockerfiles that would accept SECRET_KEY and DATABASE_URL as environment variables. Since there is no installer at the moment, I provided a more sophisticated Dockerfile as part of #867 . Maybe this addresses your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants