Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to create a Pull Request #9

Open
timmwille opened this issue Dec 8, 2020 · 2 comments
Open

How to create a Pull Request #9

timmwille opened this issue Dec 8, 2020 · 2 comments
Labels

Comments

@timmwille
Copy link
Collaborator

Pull-Request-2020-10-18 20-04

@PyGamma
Copy link
Collaborator

PyGamma commented Jan 10, 2021

This is great work Timm, Additional Instruction below to add on to your working.

  1. First is to commit or otherwise the changes you have done in you branch.
  2. Once you push the changes to your repo, the Compare & pull request button will appear in GitHub as shown below
    compare-and-pull-request-button
  3. Click it and you'll be taken to this screen:
    open-a-pull-request_crop
  4. Open a pull request by clicking the Create pull request button. This allows the repo's maintainers to review your contribution. From here, they can merge it if it is good, or they may ask you to make some changes.

In summary, if you want to contribute to a project, the simplest way is to:

Find a project you want to contribute to
Fork it
Clone it to your local system if you want to work on it locally
Make a new branch
Make your changes
Push it back to your repo
Click the Compare & pull request button
Click Create pull request to open a new pull request
If the reviewers ask for changes, repeat steps 5 and 6 to add more commits to your pull request.

@PyGamma PyGamma closed this as completed Jan 10, 2021
@bmen bmen reopened this Jan 10, 2021
@bmen
Copy link
Collaborator

bmen commented Jan 10, 2021

The page in the guide is already created, but the content still needs to be added.
https://asknet-open-training.github.io/Github-Guidance/pages/github-repo/pull-request-create/

The content can be easily added by clicking "Edit this page on GitHub" at the very bottom of the page. This will take you directly to the source.
readme-edit-this-page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants