Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 18 support #176

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Java 18 support #176

wants to merge 5 commits into from

Conversation

andre15silva
Copy link
Member

@andre15silva andre15silva commented Apr 14, 2022 •
edited
Loading

The previous PR had a bug which stopped tests from executing and in a silent way

@andre15silva andre15silva mentioned this pull request Apr 18, 2022
Closed
@andre15silva andre15silva force-pushed the java-18 branch 2 times, most recently from fc852b9 to a06340f Compare May 16, 2022 13:02
@andre15silva andre15silva force-pushed the java-18 branch 2 times, most recently from 543b960 to c548526 Compare October 12, 2022 11:17
@andre15silva
Copy link
Member Author

andre15silva commented Dec 12, 2022 •
edited
Loading

The failure is related to the asm dependency not being able to handle Java 18 classfiles:

Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 62
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:196)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:177)
	at org.objectweb.asm.ClassReader.<init>(ClassReader.java:163)
	at org.jacoco.core.internal.instr.InstrSupport.classReaderFor(InstrSupport.java:280)
	at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:108)
	at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:133)
	... 14 more

This should not happen, as the asm dependency is inherited from jacoco and should support the same classfiles as jacoco.

@andre15silva andre15silva force-pushed the java-18 branch 2 times, most recently from 1a244dd to b747b87 Compare July 19, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andre15silva