all katas #28

caberoDaniel · 2017-07-06T00:18:43Z

all katas of the coding.

codecov-io · 2017-07-06T00:21:59Z

Codecov Report

Merging #28 into develop will increase coverage by 0.22%.
The diff coverage is 95.45%.

@@              Coverage Diff              @@
##             develop      #28      +/-   ##
=============================================
+ Coverage      94.78%   95.01%   +0.22%     
- Complexity       138      210      +72     
=============================================
  Files             26       40      +14     
  Lines            307      461     +154     
  Branches          50       70      +20     
=============================================
+ Hits             291      438     +147     
- Misses             5        9       +4     
- Partials          11       14       +3

Impacted Files	Coverage Δ	Complexity Δ
...acionjala/coding/danielcabero/movies/Children.java	`100% <100%> (ø)`	`4 <4> (?)`
...ionjala/coding/danielcabero/movies/NewRelease.java	`100% <100%> (ø)`	`4 <4> (?)`
...elcabero/sorttheinnercontent/SortInnerContent.java	`100% <100%> (ø)`	`6 <6> (?)`
...anielcabero/highestandlowest/HighestAndLowest.java	`100% <100%> (ø)`	`2 <2> (?)`
...ala/coding/danielcabero/evaporator/Evaporator.java	`100% <100%> (ø)`	`3 <3> (?)`
...anielcabero/multiplesof3and5/MultiplesOf3And5.java	`100% <100%> (ø)`	`5 <5> (?)`
...undacionjala/coding/danielcabero/movies/Movie.java	`100% <100%> (ø)`	`2 <2> (?)`
...ndacionjala/coding/danielcabero/movies/Rental.java	`100% <100%> (ø)`	`5 <5> (?)`
...anielcabero/averageofnumbers/AverageOfNumbers.java	`100% <100%> (ø)`	`5 <5> (?)`
...acionjala/coding/danielcabero/movies/Customer.java	`100% <100%> (ø)`	`7 <7> (?)`
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112c303...2f06f4d. Read the comment docs.

carledriss · 2017-07-06T22:37:33Z

src/main/java/org/fundacionjala/coding/danielcabero/bank_ocr/BankOcr.java

+     * @param numberAccount image of type String.
+     * @return <code>true</code> \\ <code>false</code>
+     */
+    private static boolean size(final String numberAccount) {


refactor this method
it can be implemented in a single line of code

carledriss · 2017-07-06T22:37:49Z

src/main/java/org/fundacionjala/coding/danielcabero/bank_ocr/BankOcr.java

+     * @param numberAccount image of type String.
+     * @return <code>true</code> \\ <code>false</code>
+     */
+    private static boolean size(final String numberAccount) {


why this method is called size ?

carledriss · 2017-07-06T22:38:10Z

src/main/java/org/fundacionjala/coding/danielcabero/bank_ocr/BankOcr.java

+     * @param scannedAccount of String type.
+     * @return true.
+     */
+    private static boolean sizeImageIsValid(final String scannedAccount) {


Do we need this method?

carledriss · 2017-07-06T22:38:27Z

src/main/java/org/fundacionjala/coding/danielcabero/eanvalidator/EANValidator.java

+     * @return true if the checksum is ok.
+     */
+
+    public static boolean validate(final String eAN) {


refactor this code
avoid the else condition

carledriss · 2017-07-06T22:38:40Z

src/main/java/org/fundacionjala/coding/danielcabero/eanvalidator/EANValidator.java

+     * @param stringNumber number
+     * @return true if stringNumber length is exactly 13.
+     */
+   public static boolean checkCorrectLength(final String stringNumber) {


Do we need this method?

carledriss · 2017-07-06T22:39:21Z

src/main/java/org/fundacionjala/coding/danielcabero/movies/Main.java

+/**
+ * Created by administrator on 3/10/2017.
+ */
+public final class Main {


Remove this class since you will add unit tests

carledriss · 2017-07-06T22:40:01Z

src/test/java/org/fundacionjala/coding/danielcabero/bank_ocr/BankOcrTest.java

+        };
+
+        // when:
+        String actualResult = BankOcr.numberAccountPresentImage(scannedImage);


carledriss · 2017-07-06T22:40:08Z

src/test/java/org/fundacionjala/coding/danielcabero/bank_ocr/BankOcrTest.java

+        String actualResult = BankOcr.numberAccountPresentImage(scannedImage);
+
+        // then:
+        String expectedResult = "0123456789";


carledriss · 2017-07-06T22:40:20Z

src/test/java/org/fundacionjala/coding/danielcabero/bank_ocr/BankOcrTest.java

+        boolean actualResult = BankOcr.validateNumberAccount(incorrectAccount);
+
+        // then:
+        assertTrue(!actualResult);


assertFalse

carledriss · 2017-07-06T22:40:35Z

src/test/java/org/fundacionjala/coding/danielcabero/eanvalidator/EANValidatorTest.java

+        final boolean actualResult = EANValidator.checkCorrectLength(eanStringNumber);
+
+        // then:
+        assertTrue(!actualResult);


assertFalse

carledriss · 2017-07-06T22:40:47Z

src/test/java/org/fundacionjala/coding/danielcabero/eanvalidator/EANValidatorTest.java

+        final boolean actualResult = EANValidator.validate(eanStringNumber);
+
+        // then:
+        assertTrue(!actualResult);


assertFalse

carledriss · 2017-07-06T22:41:26Z

src/test/java/org/fundacionjala/coding/danielcabero/movies/ChildrenTest.java

+
+        // then
+        final double expectedResult = 1.5;
+        assertEquals(0, expectedResult, actualResult);


first argument should be expectedResult and the second argument should be actualResult

carledriss · 2017-07-06T22:42:01Z

src/test/java/org/fundacionjala/coding/danielcabero/movies/CustomerTest.java

+    @Test
+    public void testRentalEmpty() {
+        // given:
+        Customer customer = new Customer("Test");


you are repeating this code in all your test
Consider put it in a @before method

carledriss · 2017-07-06T22:42:19Z

src/test/java/org/fundacionjala/coding/danielcabero/movies/MainTest.java

+/**
+ * Created by Administrator on 7/5/2017.
+ */
+public class MainTest {


Do we need this test class?

carledriss · 2017-07-06T22:43:16Z

src/test/java/org/fundacionjala/coding/danielcabero/movies/MovieTest.java

+/**
+ * Created by Administrator on 7/5/2017.
+ */
+public class MovieTest {


@AT-03/at-03
Do we need this unit tests?

carledriss · 2017-07-06T22:43:31Z

src/test/java/org/fundacionjala/coding/danielcabero/movies/NewReleaseTest.java

+    @Test
+    public void testCalculateAmountWhenTheRentedDaysIsLessThanThree() {
+        // given:
+        NewRelease newReleaseInstance = new NewRelease("Test");


@AT-03/at-03
what is wrong here?

carledriss · 2017-07-06T22:44:01Z

src/test/java/org/fundacionjala/coding/danielcabero/movies/RentalTest.java

+ */
+public class RentalTest {
+
+    private Movie movie = new Movie("test") {


@AT-03/at-03
what is wrong here?

carledriss · 2017-07-11T23:42:15Z

src/main/java/org/fundacionjala/coding/danielcabero/bank_ocr/BankOcr.java

+     * @param numberAccount image of type String.
+     * @return <code>true</code> \\ <code>false</code>
+     */
+    private static boolean isCorrectLength(final String numberAccount) {


you can still refactor this

all katas

9b0abc8

carledriss reviewed Jul 6, 2017

View reviewed changes

DanielC added 3 commits July 9, 2017 22:26

all katas fix

9b11922

all katas more coverage

dafa6b3

all katas more coverage

2f06f4d

carledriss reviewed Jul 11, 2017

View reviewed changes

all katas #28

Are you sure you want to change the base?

all katas #28

Uh oh!

Conversation

caberoDaniel commented Jul 6, 2017

Uh oh!

codecov-io commented Jul 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov-io commented Jul 6, 2017 •

edited

Loading