Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested option: "BoP/Legacy Loot Items" #1895

Open
MatthewRyanRead opened this issue Jan 24, 2025 · 2 comments
Open

Suggested option: "BoP/Legacy Loot Items" #1895

MatthewRyanRead opened this issue Jan 24, 2025 · 2 comments
Labels
Suggestion New feature or request

Comments

@MatthewRyanRead
Copy link

MatthewRyanRead commented Jan 24, 2025

What flavo(u)r(s) of WoW are you using?

Retail

What problem are you experiencing that led to this feature request?

Apologies if I'm just missing something, but I can't seem to find a settings combination that quite represents "everything I can unlock while on the current character" ever since WoW made the change to let you collect the appearance of any gear that you bind or sell regardless of class/race restrictions or armor/weapon type.

From what I can tell, the closest to this would be:

  • In the General settings:
    • Checking everything under "Account-Wide Things", "General Content", "General Things", and "Expansion Things"
  • In the Filters: Using "Class Defaults" (note that these are ignored by the "Ignore BoE/Warbound Item Filters" option when applicable)

This seems to exclude BoP drops from instances using Legacy Loot. That makes sense as far as all the options are named and described, but it does prevent me from having a fully complete view of what my current character can collect (whether or not it is usable by that same character).

While on my Demon Hunter (Leather), a concrete example of such an item would be the Mail [Void-Touched Grips] from L'ura in Seat of the Triumvirate (Mythic).

If I expand the filters to include all gear types, that item will show — however, ATT will also start showing me Personal Loot items like the Plate [Legs of Graceful Landing] from Vexis in Zereth Mortis, which cannot drop for a Demon Hunter.

What solution would you like?

An option to include BoP items that can drop for and be unlocked "by" the current character regardless of whether it is unlocked "for" that character (i.e., regardless of usability). It could be similar to the existing BoE/Warbound setting, where it has a sub-option for whether to ignore the item filters.

Any alternatives you can think of?

Some kind of "Actively Unlockable" mode that would essentially just be all the options I described plus this new one? Probably overkill/clunky/difficult.

Anything else?

On #1522 and #1616 it was mentioned that the Blizzard API data around spec-restricted Personal Loot drops is poor quality (and also too large to clean up and include in ATT), but I think you could get around that by making my suggested option work via including all Legacy Loot drops (rather than trying to exclude Personal Loot drops from all drops)? If it's not feasible it's not feasible, but I'm hopeful.

Thank you for what is already the best addon in the game!

@MatthewRyanRead MatthewRyanRead added the Suggestion New feature or request label Jan 24, 2025
@ImUnicke
Copy link
Collaborator

If I expand the filters to include all gear types, that item will show — however, ATT will also start showing me Personal Loot items like the Plate [Legs of Graceful Landing] from Vexis in Zereth Mortis, which cannot drop for a Demon Hunter.

Yea this is usually the root cause of this sort of request. There's no way to 100% accurately determine "Tell me what loot Creature A can have a chance of dropping for Character B / Spec C / Loot Spec D" So we would either have a 'hacky' option which players find out is inaccurate for many situations, or we just don't try to provide that capability to avoid the inaccuracies. So far the second option has been our decision.

Someone added a PR to have the 'Quest' rewards be able to ignore these restrictions and show the 'expected' possible drops. Perhaps we could expand/duplicate that settings option to also include 'Encounters' for Instances, since I'm assuming that's a majority of the ask here. We'd of course have the same situation you already find yourself in with seeing loot that is only Personal Loot from certain Encounters... but perhaps it would be a bit less than what currently exists without the option.

@MatthewRyanRead
Copy link
Author

Yes, totally accurate to say that this is focused towards the instance encounters. I would certainly be willing to accept the same sort of situation we have with ZM rares and the API's inaccurate details.

I'll note that excluding the majority of Legacy Loot drops is considerably more inaccurate than potentially including a few things that might not drop! And from what I've seen in the wild, under Legacy Loot the only things that don't drop and are unlockable are recipes for professions you don't have, so it might be possible to get pretty quite accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants