Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix in SRP Dynamic Effector Module #471

Closed
leahkiner opened this issue Oct 30, 2023 · 0 comments · Fixed by #472
Closed

Bug Fix in SRP Dynamic Effector Module #471

leahkiner opened this issue Oct 30, 2023 · 0 comments · Fixed by #472
Assignees
@leahkiner
Labels
bug Something isn't working

Comments

@leahkiner
Copy link
Contributor

Describe the bug
The module double counts the cos(theta) variable in the SRP force calculation.

To reproduce
The bug is not visually apparent, as it is only a numerical calculation error.

Expected behavior
The bug is not visually apparent, as it is only a numerical calculation error.

Desktop (please complete the following information):

  • OS: Ventura
  • Version 13.0
  • Python version 3.11.2

Additional context
N/A
@leahkiner leahkiner added the bug Something isn't working label Oct 30, 2023
@leahkiner leahkiner self-assigned this Oct 30, 2023
@leahkiner leahkiner moved this to 🏗 In progress in Basilisk Oct 30, 2023
@leahkiner leahkiner mentioned this issue Oct 30, 2023
Merged
@schaubh schaubh linked a pull request Oct 30, 2023 that will close this issue
Fix Bug in SRP Dynamic Effector Module #472
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Basilisk Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leahkiner leahkiner

Labels
bug Something isn't working
Projects
Basilisk
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Bug in SRP Dynamic Effector Module AVSLab/basilisk
1 participant
@leahkiner