Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating additional windows does not keep opportunities sorted #205

Open
Mark2000 opened this issue Oct 8, 2024 · 0 comments
Open

Generating additional windows does not keep opportunities sorted #205

Mark2000 opened this issue Oct 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Mark2000
Copy link
Contributor

Mark2000 commented Oct 8, 2024

Describe the bug
The opportunities list is expected to be sorted by close time. It is possible to break this.

To Reproduce
Steps to reproduce the behavior:

  1. Generate two segments of opportunities (as opposed to all at once).
  2. Observe the order of the opportunities list; it is not sorted around the time where the two opportunity generations met.

Expected behavior
Opportunities should always remain sorted.

Additional context
I suspect this comes from not properly reordering opportunities when one of the form [opportunity_start, opportunity_generation_end_time] is extended to [opportunity_start, opportunity_end]. For now, just generate all of your opportunities at once to avoid this issue.

@Mark2000 Mark2000 added the bug Something isn't working label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant