Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D] Order Id could overflow potentially #246

Closed
nus-se-bot opened this issue Oct 31, 2021 · 1 comment
Closed

[PE-D] Order Id could overflow potentially #246

nus-se-bot opened this issue Oct 31, 2021 · 1 comment

Comments

@nus-se-bot
Copy link

Order Id increments after each addition, so what if there are too many orders to be displayed?

image.png

Labels: severity.Low type.FeatureFlaw
original: muhammad-khair/ped#11
@lwlshawn
Copy link
Collaborator

Upper limit of long is 9,223,372,036,854,775,807. This is on the order of 10^18, If you keyed in 1000 orders a day, it would still take you 10^15 days to overflow, or over 2 trillion years

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lwlshawn @nus-se-bot