Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester A] Wrong error thrown for index < 1 #161

Closed
soc-se-bot opened this issue Oct 28, 2022 · 1 comment · Fixed by #207
Closed

[PE-D][Tester A] Wrong error thrown for index < 1 #161

soc-se-bot opened this issue Oct 28, 2022 · 1 comment · Fixed by #207
Assignees
@Benjamin-Sim
Labels
severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product type.Bug Something isn't working type.Documentation Improvements or additions to documentation

Comments

@soc-se-bot
Copy link

Under editPerson command, when an invalid index is passed, "The person index provided is invalid" should be displayed. However for values below 1 it throws an incorrect formatting error instead.

Screenshot 2022-10-28 at 4.27.34 PM.png

Screenshot 2022-10-28 at 4.27.23 PM.png

Labels: severity.VeryLow type.FunctionalityBug
original: ama-chi/ped#1
@lfrostbytee lfrostbytee added type.Documentation Improvements or additions to documentation severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product type.Bug Something isn't working labels Oct 30, 2022
@Benjamin-Sim
Copy link

Explain 0 and -1 behaviour in user guide

@Benjamin-Sim Benjamin-Sim mentioned this issue Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Benjamin-Sim Benjamin-Sim

Labels
severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product type.Bug Something isn't working type.Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge branch-BugFixWrongErrorMessageForNonPositiveIndex with Master Benjamin-Sim/tp
3 participants
@lfrostbytee @Benjamin-Sim @soc-se-bot