From ec5b6ac0e23cefd290cb704b4883f423aa9ad4f8 Mon Sep 17 00:00:00 2001 From: Caden <63772723+cadencjk@users.noreply.github.com> Date: Sun, 16 Oct 2022 11:44:20 +0800 Subject: [PATCH] Fix style issues --- src/main/java/seedu/address/model/person/Person.java | 6 +++--- src/main/java/seedu/address/ui/ScheduleCard.java | 3 +-- src/test/java/seedu/address/model/person/PersonTest.java | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/main/java/seedu/address/model/person/Person.java b/src/main/java/seedu/address/model/person/Person.java index 805647df9b4..73a0a369d9d 100644 --- a/src/main/java/seedu/address/model/person/Person.java +++ b/src/main/java/seedu/address/model/person/Person.java @@ -140,11 +140,11 @@ public boolean isSamePerson(Person otherPerson) { } /** - * Determines whether the person owes money. + * Determines whether the person is owing money. * - * @return true if the person owes money + * @return true if the person is owing money */ - public boolean owesMoney() { + public boolean isOwingMoney() { return moneyOwed.isGreaterThanZero(); } diff --git a/src/main/java/seedu/address/ui/ScheduleCard.java b/src/main/java/seedu/address/ui/ScheduleCard.java index a5541ba7086..4e3874d4149 100644 --- a/src/main/java/seedu/address/ui/ScheduleCard.java +++ b/src/main/java/seedu/address/ui/ScheduleCard.java @@ -12,7 +12,6 @@ public class ScheduleCard extends UiPart { private static final String FXML = "ScheduleListCard.fxml"; - private static final String COLOUR_OF_DEBTOR = "-fx-text-fill: #FF0000;"; /** @@ -56,7 +55,7 @@ public ScheduleCard(Person person, int displayedIndex) { * @param person to check whether he/she is a debtor */ private void setWarningIfOwed(Person person) { - if (person.owesMoney()) { + if (person.isOwingMoney()) { String nameWithAmount = person.getName().fullName + " - To collect $" + person.getMoneyOwed().value; name.setText(nameWithAmount); name.setStyle(COLOUR_OF_DEBTOR); diff --git a/src/test/java/seedu/address/model/person/PersonTest.java b/src/test/java/seedu/address/model/person/PersonTest.java index c054195dac0..f40808c0b76 100644 --- a/src/test/java/seedu/address/model/person/PersonTest.java +++ b/src/test/java/seedu/address/model/person/PersonTest.java @@ -105,10 +105,10 @@ public void execute_setClassSuccess() { @Test public void owesMoneyTest() { Person debtor = AVA; - assertTrue(debtor.owesMoney()); + assertTrue(debtor.isOwingMoney()); Person nonDebtor = new PersonBuilder(AVA).withMoneyOwed(0).build(); - assertFalse(nonDebtor.owesMoney()); + assertFalse(nonDebtor.isOwingMoney()); } }