Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Claim Issue #63

Merged
merged 13 commits into from
Oct 9, 2023
Merged

Edit Claim Issue #63

merged 13 commits into from
Oct 9, 2023

Conversation

sheryew
Copy link

@sheryew sheryew commented Oct 9, 2023

Basic functionality including negative scenarios are settled.
Test cases for ClaimCommand & ClaimCommandParser are also added.

@sheryew sheryew added this to the v1.2 milestone Oct 9, 2023
@sheryew sheryew linked an issue Oct 9, 2023 that may be closed by this pull request
Claims [Edit claims for an employee] #40
Closed
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5a9ae35) 75.08% compared to head (41ac68c) 75.46%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
+ Coverage     75.08%   75.46%   +0.37%     
- Complexity      450      471      +21     
============================================
  Files            76       79       +3     
  Lines          1501     1565      +64     
  Branches        145      155      +10     
============================================
+ Hits           1127     1181      +54     
- Misses          330      333       +3     
- Partials         44       51       +7
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 90.90% <ø> (ø)
...seedu/address/logic/parser/ClaimCommandParser.java 100.00% <100.00%> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 90.90% <100.00%> (+0.90%) ⬆️
.../seedu/address/logic/parser/EditCommandParser.java 100.00% <ø> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 87.93% <100.00%> (+1.65%) ⬆️
.../seedu/address/logic/parser/AddressBookParser.java 90.47% <0.00%> (-9.53%) ⬇️
...rc/main/java/seedu/address/model/person/Claim.java 72.72% <72.72%> (ø)
...ava/seedu/address/logic/commands/ClaimCommand.java 84.84% <84.84%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

remuslum
remuslum approved these changes Oct 9, 2023
View reviewed changes
Copy link

@remuslum remuslum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@remuslum remuslum merged commit 6a3a32e into AY2324S1-CS2103-F13-2:master Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remuslum remuslum remuslum approved these changes

@nixonwidjaja nixonwidjaja Awaiting requested review from nixonwidjaja

@marcellaantania marcellaantania Awaiting requested review from marcellaantania

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Claims [Edit claims for an employee]
2 participants
@sheryew @remuslum