-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutor function #61
Add tutor function #61
Conversation
ruishanteo
commented
Oct 6, 2023
•
edited by mfjkri
Loading
edited by mfjkri
- Refactor person model
- Remove address
- Remove tags
- Add add tutor command
- Edit edit person command (for updated person model)
Codecov Report
@@ Coverage Diff @@
## refactor-person-as-tutor #61 +/- ##
==============================================================
- Coverage 75.26% 74.15% -1.12%
+ Complexity 419 400 -19
==============================================================
Files 71 70 -1
Lines 1338 1265 -73
Branches 126 114 -12
==============================================================
- Hits 1007 938 -69
+ Misses 301 298 -3
+ Partials 30 29 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rui Shan. LGTM!
@Jweng88 Please use this branch for list and edit command (your PRs should merge back to this branch instead of master).
We will ensure coverage report is acceptable before merging this branch back to master.
58fa591
into
AY2324S1-CS2103T-T17-3:refactor-person-as-tutor