Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutor function #61

Conversation

ruishanteo
Copy link

@ruishanteo ruishanteo commented Oct 6, 2023

  • Refactor person model
  • Remove address
  • Remove tags
  • Add add tutor command
  • Edit edit person command (for updated person model)

@ruishanteo ruishanteo added priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic labels Oct 6, 2023
@ruishanteo ruishanteo added this to the v1.2 milestone Oct 6, 2023
@ruishanteo ruishanteo self-assigned this Oct 6, 2023
@ruishanteo ruishanteo added type.Story A user story and removed type.Task Something that needs to be done, but not a story, bug, or an epic labels Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #61 (5cee758) into refactor-person-as-tutor (f9831d0) will decrease coverage by 1.12%.
The diff coverage is 96.42%.

@@                      Coverage Diff                       @@
##             refactor-person-as-tutor      #61      +/-   ##
==============================================================
- Coverage                       75.26%   74.15%   -1.12%     
+ Complexity                        419      400      -19     
==============================================================
  Files                              71       70       -1     
  Lines                            1338     1265      -73     
  Branches                          126      114      -12     
==============================================================
- Hits                             1007      938      -69     
+ Misses                            301      298       -3     
+ Partials                           30       29       -1     
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 83.33% <100.00%> (-4.17%) ⬇️
.../seedu/address/logic/commands/AddTutorCommand.java 100.00% <100.00%> (ø)
...java/seedu/address/logic/commands/EditCommand.java 96.87% <100.00%> (-0.57%) ⬇️
...du/address/logic/parser/AddTutorCommandParser.java 100.00% <100.00%> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <100.00%> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 75.00% <100.00%> (-17.60%) ⬇️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% <ø> (-20.00%) ⬇️
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <100.00%> (ø)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <ø> (ø)
...c/main/java/seedu/address/model/person/Person.java 96.29% <75.00%> (-0.93%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mfjkri mfjkri linked an issue Oct 7, 2023 that may be closed by this pull request
@mfjkri mfjkri changed the base branch from master to refactor-person-as-tutor October 7, 2023 07:48
Copy link

@mfjkri mfjkri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rui Shan. LGTM!

@Jweng88 Please use this branch for list and edit command (your PRs should merge back to this branch instead of master).

We will ensure coverage report is acceptable before merging this branch back to master.

@mfjkri mfjkri merged commit 58fa591 into AY2324S1-CS2103T-T17-3:refactor-person-as-tutor Oct 7, 2023
4 of 5 checks passed
@mfjkri mfjkri linked an issue Oct 8, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extra fields from Person
2 participants