From 7ba71b593d6d4af6cf5523ad2d27d30127adce94 Mon Sep 17 00:00:00 2001 From: samuelmui8 Date: Thu, 26 Oct 2023 23:43:23 +0800 Subject: [PATCH] Fix storage bug where itemReview is null --- .../java/seedu/address/storage/JsonAdaptedItem.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/main/java/seedu/address/storage/JsonAdaptedItem.java b/src/main/java/seedu/address/storage/JsonAdaptedItem.java index 6fc05cf9d0b..63590f1c3b0 100644 --- a/src/main/java/seedu/address/storage/JsonAdaptedItem.java +++ b/src/main/java/seedu/address/storage/JsonAdaptedItem.java @@ -49,13 +49,17 @@ public Item toModelType() throws IllegalValueException { throw new IllegalValueException(ItemName.MESSAGE_CONSTRAINTS); } final ItemName modelName = new ItemName(itemName); - Item item = new Item(modelName); - final ItemReview modelItemReview = itemReview.toModelType(); + ItemReview modelItemReview = null; + + if (itemReview != null) { + modelItemReview = itemReview.toModelType(); + } if (modelItemReview != null) { - item.setItemReview(modelItemReview); + return new Item(modelName, modelItemReview); + } else { + return new Item(modelName); } - return item; } }