Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester C] Edit With No Specified Path Result in No Visible Change in Student Information #227

Closed
Tracked by #262
soc-se-bot opened this issue Nov 3, 2023 · 2 comments

Comments

@soc-se-bot
Copy link

Screenshot 2023-11-03 at 4.35.35 PM.png

Screenshot 2023-11-03 at 4.36.51 PM.png

Every parameter in the edit command was optional. Therefore, I typed "edit -n Woojoo" under the group directory. This resulted in the the following command result: "Field(s) of group has been edited successfully.", but no visible changes were available. Instead, I changed the group name. This was different from what the UG said, I believe (the edit command is supposed to edit student details) I think maybe you can make the Specified_Path parameter mandatory under group directory to fix this issue (To make sure there is a student that is being edited)


Labels: severity.Medium type.FunctionalityBug
original: hjoneweek/ped#3

@NereusWB922
Copy link
Collaborator

NereusWB922 commented Nov 4, 2023

Edit command with optional path is to allow user to edit field of current directory (in this case the group), so user don't need navigate to root to edit groups' fields. Will consider enhancement to show the field of current directory in display panel.

@mingyuanc
Copy link

  1. efficiency
  2. model closely to the real terminal app
    if want to see change then cd out

@mingyuanc mingyuanc added this to the v1.4 milestone Nov 5, 2023
This was referenced Nov 6, 2023
@zannloo zannloo closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants