From 278f86063585cd63007719e1f0bb24eee7fd4f31 Mon Sep 17 00:00:00 2001 From: liauzhanyi Date: Tue, 12 Nov 2024 10:22:21 +0800 Subject: [PATCH 1/4] Clarify duplicate contact in User Guide --- docs/UserGuide.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 7d002c8761a..7e32fdc37c8 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -345,6 +345,12 @@ _Details coming soon ..._ - The "remarks" field is meant for long form notes about a person. This is likely to be quite cumbersome to enter at the same time that a person is being added for the first time. - Users are recommended to first `add` the person to the address list, and then subsequently use the `edit` or `remark` commands to write remarks about a contact. +**Q3**: Why are (only) name and phone used to determine duplicate? +- To explain this, we look at the following cases and explain why they should not be considered a duplicate. +- For persons with the same name but different phone number, this is a common case. +- For persons with different name but same phone number, this is deliberate consideration we made given that in the field of social work. One example is where the beneficiaries lives in shared rental flat and people living in the same household might share the same phone number but for the social worker, he/she might want to remember each person's contact separately. +- For persons with different name and different phone number, we think this is trivial and does not need explaination. + -------------------------------------------------------------------------------------------------------------------- ## Known issues From 18db7479e223097dc07390f22c4dafef01ef7517 Mon Sep 17 00:00:00 2001 From: liauzhanyi Date: Tue, 12 Nov 2024 10:27:02 +0800 Subject: [PATCH 2/4] Clarify duplicate definition --- docs/UserGuide.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 7e32fdc37c8..68045534d73 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -345,11 +345,12 @@ _Details coming soon ..._ - The "remarks" field is meant for long form notes about a person. This is likely to be quite cumbersome to enter at the same time that a person is being added for the first time. - Users are recommended to first `add` the person to the address list, and then subsequently use the `edit` or `remark` commands to write remarks about a contact. -**Q3**: Why are (only) name and phone used to determine duplicate? +**Q3**: How does SocialBook determine a duplicate contact? +- First of all, we consider a duplicate as a person having both identical name (case-insensitive) and phone number. - To explain this, we look at the following cases and explain why they should not be considered a duplicate. - For persons with the same name but different phone number, this is a common case. - For persons with different name but same phone number, this is deliberate consideration we made given that in the field of social work. One example is where the beneficiaries lives in shared rental flat and people living in the same household might share the same phone number but for the social worker, he/she might want to remember each person's contact separately. -- For persons with different name and different phone number, we think this is trivial and does not need explaination. +- For persons with different name and different phone number, we think this is trivial and does not need explanation. -------------------------------------------------------------------------------------------------------------------- From 3dccb5ba845b3d53fb31de768a225f28320de344 Mon Sep 17 00:00:00 2001 From: liauzhanyi Date: Tue, 12 Nov 2024 10:30:01 +0800 Subject: [PATCH 3/4] Update duplicate definition in User Guide --- docs/UserGuide.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 68045534d73..1e88236ad64 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -347,10 +347,10 @@ _Details coming soon ..._ **Q3**: How does SocialBook determine a duplicate contact? - First of all, we consider a duplicate as a person having both identical name (case-insensitive) and phone number. -- To explain this, we look at the following cases and explain why they should not be considered a duplicate. -- For persons with the same name but different phone number, this is a common case. -- For persons with different name but same phone number, this is deliberate consideration we made given that in the field of social work. One example is where the beneficiaries lives in shared rental flat and people living in the same household might share the same phone number but for the social worker, he/she might want to remember each person's contact separately. -- For persons with different name and different phone number, we think this is trivial and does not need explanation. +- To understand this, we look at the following cases and explain why they should not be considered a duplicate. +- Persons with the same name but different phone numbers are common, and are clearly not duplicates. +- Persons with different names but the same phone number can exist in the field of social work, and should not be considered duplicates. If multiple beneficiaries live in the same shared rental flat, they may share the same phone number (on a landline). For the social worker to remember each person's contact separately, it makes sense to not mark these contacts as duplicates so that remarks and tags can be added to each person's contact. +- Persons with different names and different phone numbers are definitely different people, and are thus not duplicates. -------------------------------------------------------------------------------------------------------------------- From 185ab28a89aa1b952cdc36b1a0d53fa8826b2973 Mon Sep 17 00:00:00 2001 From: liauzhanyi Date: Tue, 12 Nov 2024 10:56:25 +0800 Subject: [PATCH 4/4] Fix typo in UG --- docs/UserGuide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/UserGuide.md b/docs/UserGuide.md index 1e88236ad64..2aedebb10fe 100644 --- a/docs/UserGuide.md +++ b/docs/UserGuide.md @@ -349,7 +349,7 @@ _Details coming soon ..._ - First of all, we consider a duplicate as a person having both identical name (case-insensitive) and phone number. - To understand this, we look at the following cases and explain why they should not be considered a duplicate. - Persons with the same name but different phone numbers are common, and are clearly not duplicates. -- Persons with different names but the same phone number can exist in the field of social work, and should not be considered duplicates. If multiple beneficiaries live in the same shared rental flat, they may share the same phone number (on a landline). For the social worker to remember each person's contact separately, it makes sense to not mark these contacts as duplicates so that remarks and tags can be added to each person's contact. +- Persons with different names but the same phone number can exist in the field of social work, and should not be considered duplicates. If multiple beneficiaries live in the same shared rental flat, they may share the same phone number (on a landline). For the social worker to remember each person's contact separately, it makes sense to not mark these contacts as duplicates so that remarks and tags can be added to each person's contact. - Persons with different names and different phone numbers are definitely different people, and are thus not duplicates. --------------------------------------------------------------------------------------------------------------------