From 0d2589923a7cb6b2ee88ed14e0e52b9b243e3348 Mon Sep 17 00:00:00 2001 From: AbdulrahmanAlRammah <142239643+AbdulrahmanAlRammah@users.noreply.github.com> Date: Tue, 12 Nov 2024 11:06:57 +0800 Subject: [PATCH 1/2] Update enhancements --- docs/DeveloperGuide.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index b78779c9721..a81a3431118 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -622,4 +622,5 @@ For reference, our group has 5 members. 6. Update the error message displayed to the user by the `remark` command upon attempt to index with 0. The current error message for `remark 0 r/Hates frisbees` states "invalid command format" when it should mention that the index provided is invalid. 7. Update the error message displayed to the user by the `delete` command upon attempt to index with 0. The current error message for `delete 0` states "invalid command format" when it should mention that the index provided is invalid. 8. Update the error message displayed to the user by the `view` command upon attempt to index with 0. The current error message for `view 0` states "invalid command format" when it should mention that the index provided is invalid. -9. Include an example of sorting by date of last visit (`d/`) in the command format message of the `sort` command. +9. Include an example of sorting by date of last visit (`d/`) in the command format message of the `sort` command. +10. Improve clarity of emergency contact error message for invalid input. Currently, entering an invalid emergency contact will give an error message about phone numbers. This can be confusing when editing a phone number and emergency contact simultaneously. The message will be edited to more explicitly mention emergency contact and the specific issue. From 1c9f7ecbef6c8c7226c74cd3518a0339268b7118 Mon Sep 17 00:00:00 2001 From: AbdulrahmanAlRammah <142239643+AbdulrahmanAlRammah@users.noreply.github.com> Date: Tue, 12 Nov 2024 11:15:47 +0800 Subject: [PATCH 2/2] Add phone number enhancement --- docs/DeveloperGuide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index a81a3431118..0060b8dc5a4 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -622,5 +622,5 @@ For reference, our group has 5 members. 6. Update the error message displayed to the user by the `remark` command upon attempt to index with 0. The current error message for `remark 0 r/Hates frisbees` states "invalid command format" when it should mention that the index provided is invalid. 7. Update the error message displayed to the user by the `delete` command upon attempt to index with 0. The current error message for `delete 0` states "invalid command format" when it should mention that the index provided is invalid. 8. Update the error message displayed to the user by the `view` command upon attempt to index with 0. The current error message for `view 0` states "invalid command format" when it should mention that the index provided is invalid. -9. Include an example of sorting by date of last visit (`d/`) in the command format message of the `sort` command. +9. Improve clarity of phone number parsing message to give users clearer direction on the issue with the entered phone number (ex. to remove accidental extra spaces). 10. Improve clarity of emergency contact error message for invalid input. Currently, entering an invalid emergency contact will give an error message about phone numbers. This can be confusing when editing a phone number and emergency contact simultaneously. The message will be edited to more explicitly mention emergency contact and the specific issue.