Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error installing OpenEXR with pip #1855

Closed
aarondemolder opened this issue Oct 1, 2024 · 11 comments
Closed

Error installing OpenEXR with pip #1855

aarondemolder opened this issue Oct 1, 2024 · 11 comments

Comments

@aarondemolder
Copy link
Contributor

aarondemolder commented Oct 1, 2024

I was excited to see the new python bindings but I'm having some trouble on macos Sonoma 14.5.

I'm not sure if this is an issue on my end or if something needs adjusting.

Log from pip attached:

cmd_2024-10-01_17.00.40_pip_errors.log

@cary-ilm
Copy link
Member

cary-ilm commented Oct 1, 2024

That looks like a problem with the distribution. It's incorrectly looking for a test directory that is not included with the sdist. I'll investigate further.

It's a workaround for now, but you might try cloning the repo and building from source.

@aarondemolder
Copy link
Contributor Author

Thanks Cary! No rush on my side really, let me know if it's handy for me to test anything

@RafaelWO
Copy link
Contributor

RafaelWO commented Oct 2, 2024

I have the same issue. As far as I know OpenEXR usually ships pre-built binaries to PyPI but for some reason version 3.3.0 does not include files for Python 3.12. Could this be part of the issue?

P.S. Version 3.2.4 does include builds for 3.12 though.

@RafaelWO
Copy link
Contributor

RafaelWO commented Oct 2, 2024

I noticed that the GH workflow for building Python wheels does not include Python 3.12. Happy to create a PR if this should be added 🙂

P.S. The Python 3.13 release is also around the corner 🐍

@cary-ilm
Copy link
Member

cary-ilm commented Oct 2, 2024

Hmm, I had removed python 3.12 at one point during development because the build failed, but trying it again now, it does seem to work. Please do submit a PR, thanks!

#1857 should fix the sdist/macOS 14.5 problem, we'll make a patch shortly.

@RafaelWO
Copy link
Contributor

RafaelWO commented Oct 2, 2024

Hmm, I had removed python 3.12 at one point during development because the build failed, but trying it again now, it does seem to work. Please do submit a PR, thanks!

I create a PR: #1861 🙂

@jonwolski
Copy link

I'm not sure if this is an issue on my end or if something needs adjusting.

Not just you.

Here's a minimal test case to reproduce the issue:

docker run -it python:3.11-bookworm python -m pip install openexr==3.3.0

I've tried openexr==3.2.3, …==3.2.4, and …==3.3.0 all to the same effect.

I've also tried python 3.10, and bullseye instead of bookworm.

@cary-ilm
Copy link
Member

cary-ilm commented Oct 9, 2024

This should be fixed in v3.3.1, released just now. Give the wheel an hour or so to get built.

@jonwolski
Copy link

jonwolski commented Oct 9, 2024

Thank you a 2^20, @cary-ilm ! I have confirmed v3.3.1 works for me.

You're a super hero

@cary-ilm
Copy link
Member

cary-ilm commented Oct 9, 2024

Glad to hear it, thanks!

@aarondemolder
Copy link
Contributor Author

Also now works for me!
Seeing as there's new issues for taking a look at pip install without a binary, I think this can be closed.
Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants