Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible text parsing system #134

Closed
Acclorite opened this issue Dec 30, 2024 · 0 comments
Closed

Flexible text parsing system #134

Acclorite opened this issue Dec 30, 2024 · 0 comments
Assignees
Labels
⏳ Awaiting release Issue that was resolved in one of the commits and now awaiting release 🚀 Feature request New feature request or improvement

Comments

@Acclorite
Copy link
Owner

Acclorite commented Dec 30, 2024

Why you want this feature to be implemented? Please describe.
When I think about uselessness, one thing explicitly comes to my mind—the text update and storing system (I think @shuvashish76 told me something similar). It has its pluses, for example, faster reader loading time, less dependency on files themselves, and maybe some more.

But what it really lacks is flexibility. I cannot easily change the whole reader, as that whole thing will need migration. What I want is a flexible solution that does not overcomplicate the UI and code—parsing files directly each time, without storing text in the app's storage. It will open the door to something bigger, such as Images (#69), Nested Chapters (#130), skip parsing in Browse, and more.

Describe the feature you'd like to be implemented
Simplify the code, remove text update, remove text storage. Directly parse text from the file each time user enters the Reader.

@Acclorite Acclorite added the 🚀 Feature request New feature request or improvement label Dec 30, 2024
@Acclorite Acclorite added this to the Reader Improvement milestone Dec 30, 2024
@Acclorite Acclorite self-assigned this Dec 30, 2024
@Acclorite Acclorite moved this to In progress in Book's Story: Roadmap 🌌 Dec 30, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Book's Story: Roadmap 🌌 Dec 30, 2024
@Acclorite Acclorite added the ⏳ Awaiting release Issue that was resolved in one of the commits and now awaiting release label Dec 30, 2024
Acclorite added a commit that referenced this issue Jan 1, 2025
* Reformatted parsers
* Direct parsing
* Scalable
* Slightly faster parsing (no optimizations yet)

Part-of: #134
Acclorite added a commit that referenced this issue Jan 11, 2025
* Delete booksDir(if exists), which does not serve any purpose

Part-of: #134
@Acclorite Acclorite mentioned this issue Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏳ Awaiting release Issue that was resolved in one of the commits and now awaiting release 🚀 Feature request New feature request or improvement
Projects
Status: Done
Development

No branches or pull requests

1 participant