Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port code from the HA integration #13

Open
kristofferR opened this issue Dec 23, 2022 · 2 comments
Open

Port code from the HA integration #13

kristofferR opened this issue Dec 23, 2022 · 2 comments

Comments

@kristofferR
Copy link

I'm not sure if you're aware, but the implementation of the Roborock API that @rovo89 managed to create has been utilized for a Home Assistant integration that has progressed quite far already.

I'm sure the code there could help you to develop this adapter:
https://github.com/humbertogontijo/homeassistant-roborock

@rovo89
Copy link

rovo89 commented Dec 23, 2022

I wasn't aware of it, but it's great to see that it's more than a proof of concept now. 😊

From a software architecture and reusability point of view, I think it would make sense to package the low level API (basically the code from the Gist) into an npm package, and maybe even have another package with a higher-level API. Problem: I haven't done anything with Node.js/npm before, so I have to research how to do that 😂

I thought maybe something could be extracted back from HA, but it's Python. Same thoughts there, but I'd concentrate on Node.js first.

@kristofferR
Copy link
Author

kristofferR commented Dec 23, 2022

I wasn't aware of it, but it's great to see that it's more than a proof of concept now. 😊

From a software architecture and reusability point of view, I think it would make sense to package the low level API (basically the code from the Gist) into an npm package, and maybe even have another package with a higher-level API. Problem: I haven't done anything with Node.js/npm before, so I have to research how to do that 😂

I thought maybe something could be extracted back from HA, but it's Python. Same thoughts there, but I'd concentrate on Node.js first.

I think the python code will be useful to understand the API calls/usage, especially the complicated ones for the map gathering/rendering.

Thanks so much for the API decompilation BTW, glad to see that you're aware of how excited so many people are about it. Not being forced to use the Xiaomi Home app anymore is a revolution for so many people.

If you're looking for your next decompilation challenge, the front video camera would be a good candidate:
humbertogontijo/homeassistant-roborock#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants