Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI in python3 as well #51

Open
Achllle opened this issue Feb 18, 2020 · 2 comments
Open

Run CI in python3 as well #51

Achllle opened this issue Feb 18, 2020 · 2 comments
Assignees
Labels
CI continuous integration enhancement New feature or request

Comments

@Achllle
Copy link
Owner

Achllle commented Feb 18, 2020

Run dual_quaternions tests with Python3 in Travis CI. This requires a few modifications:

  1. In setup.py, from distutils.core import setup --> from setuptools import setup although this old article says it doesn't like it but I think that can be disregarded.
  2. Code needs to become python3 compatible. Just need to fix one test!
  3. Modify Travis config to run python3. Not sure how that would work with ROS installation.
@Achllle Achllle added enhancement New feature or request CI continuous integration labels Feb 18, 2020
@Achllle Achllle self-assigned this Feb 18, 2020
@mjsobrep
Copy link
Collaborator

on 3: you might just want to have a seperate job so that it tries it with clean python 3, assuming ROS isn't really needed. Then you can have tests that isolate the different use cases.

Also: just started using github actions, pretty cool

@Achllle
Copy link
Owner Author

Achllle commented Feb 20, 2020

That's the plan. I saw github actions, might try that for the next project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants