Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent EXERCISE_VALVE being sent twice to eTRV #39

Open
Achronite opened this issue Jan 23, 2024 · 1 comment
Open

Prevent EXERCISE_VALVE being sent twice to eTRV #39

Achronite opened this issue Jan 23, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Achronite
Copy link
Owner

Achronite commented Jan 23, 2024 •
edited
Loading

Because any outstanding cached command is immediately sent for an eTRV there is a possibility that commands such as EXERCISE_VALVE are executed twice.

This change would quickly check Rec 0 of the eTRV message and perform appropriately. For EXERCISE_VALVE rec 0 is DIAGNOSTICS, but other commands require further investigation.
@Achronite Achronite added the enhancement New feature or request label Jan 23, 2024
@genestealer
Copy link

Ah, I have seen this behaviour myself with the eTRV "calibrating" twice, I did wonder what was going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@genestealer @Achronite