From 29fd2b279773460b286276b97ca3908119bd47d4 Mon Sep 17 00:00:00 2001 From: Igor Balos Date: Tue, 12 Nov 2019 15:52:20 +0100 Subject: [PATCH] deprecated bounce tags --- lib/postmark/api_client.rb | 4 ---- lib/postmark/bounce.rb | 4 ---- lib/postmark/version.rb | 2 +- spec/unit/postmark/api_client_spec.rb | 9 --------- spec/unit/postmark/bounce_spec.rb | 10 ---------- 5 files changed, 1 insertion(+), 28 deletions(-) diff --git a/lib/postmark/api_client.rb b/lib/postmark/api_client.rb index 48f1efb..d92cf96 100644 --- a/lib/postmark/api_client.rb +++ b/lib/postmark/api_client.rb @@ -135,10 +135,6 @@ def get_bounces(options = {}) batch end - def get_bounced_tags - http_client.get("bounces/tags") - end - def get_bounce(id) format_response http_client.get("bounces/#{id}") end diff --git a/lib/postmark/bounce.rb b/lib/postmark/bounce.rb index e85d8ca..cf87cb7 100644 --- a/lib/postmark/bounce.rb +++ b/lib/postmark/bounce.rb @@ -54,10 +54,6 @@ def all(options = {}) Bounce.new(bounce_json) end end - - def tags - Postmark.api_client.get_bounced_tags - end end end diff --git a/lib/postmark/version.rb b/lib/postmark/version.rb index 9c841c5..b8006c2 100644 --- a/lib/postmark/version.rb +++ b/lib/postmark/version.rb @@ -1,3 +1,3 @@ module Postmark - VERSION = '1.19.0' + VERSION = '1.19.1' end diff --git a/spec/unit/postmark/api_client_spec.rb b/spec/unit/postmark/api_client_spec.rb index 456d158..60c092f 100644 --- a/spec/unit/postmark/api_client_spec.rb +++ b/spec/unit/postmark/api_client_spec.rb @@ -398,15 +398,6 @@ end end - describe "#get_bounced_tags" do - let(:http_client) {subject.http_client} - - it 'requests data at /bounces/tags' do - expect(http_client).to receive(:get).with("bounces/tags") - subject.get_bounced_tags - end - end - describe "#get_bounce" do let(:http_client) {subject.http_client} let(:id) {42} diff --git a/spec/unit/postmark/bounce_spec.rb b/spec/unit/postmark/bounce_spec.rb index 1973515..3badbca 100644 --- a/spec/unit/postmark/bounce_spec.rb +++ b/spec/unit/postmark/bounce_spec.rb @@ -120,14 +120,4 @@ expect(Postmark::Bounce.all.count).to eq(3) end end - - describe ".tags" do - let(:api_client) { Postmark.api_client } - let(:tags) { ["tag1", "tag2"] } - - it "calls #get_bounced_tags on shared api_client instance" do - expect(api_client).to receive(:get_bounced_tags) { tags } - expect(Postmark::Bounce.tags).to eq tags - end - end end \ No newline at end of file