Prevent API parse error when names contain quotes #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, it's possible to call `message.setTo(Map.of(name, address))` without first having to escape the `name`.
|
@ibalosh gently pinging you in case you missed some notifications 🙂 What do you think, are there any changes you can think of, or does it look ok? |
|
Hi @fibbers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, it's possible to call
message.setTo(Map.of(name, address))without first having to escape thename.This should fix #65.
Note:
.replacecall, I can change it.assertEqualsare reversed: expected <-> actual. I didn't modify them to keep this PR focused, but just so you know.