diff --git a/lib/max_subarray.rb b/lib/max_subarray.rb index 5204edb..d6ad567 100644 --- a/lib/max_subarray.rb +++ b/lib/max_subarray.rb @@ -1,8 +1,16 @@ - -# Time Complexity: ? -# Space Complexity: ? +# Time Complexity: O(n) +# Space Complexity: O(1) def max_sub_array(nums) return 0 if nums == nil - - raise NotImplementedError, "Method not implemented yet!" -end + return nil if nums.empty? + max = nums[0] + sum = 0 + i = 0 + while i < nums.length + sum += nums[i] + max = sum if sum > max + sum = 0 if sum < 0 + i += 1 + end + return max + end \ No newline at end of file diff --git a/lib/newman_conway.rb b/lib/newman_conway.rb index 4c985cd..c8d26fe 100644 --- a/lib/newman_conway.rb +++ b/lib/newman_conway.rb @@ -1,7 +1,16 @@ - - -# Time complexity: ? -# Space Complexity: ? +# Time complexity: O(n) +# Space Complexity: O(n) def newman_conway(num) - raise NotImplementedError, "newman_conway isn't implemented" -end \ No newline at end of file + raise ArgumentError if num < 1 + return "1" if num == 1 + sequence = [0, 1, 1] + i = 3 + result = "1 1" + until i >= num + 1 + current = sequence[sequence[i-1]] + sequence[i - (sequence[i-1])] + sequence << current + result += " #{current}" + i += 1 + end + return result +end \ No newline at end of file diff --git a/test/max_sub_array_test.rb b/test/max_sub_array_test.rb index 3253cdf..e27e1ca 100644 --- a/test/max_sub_array_test.rb +++ b/test/max_sub_array_test.rb @@ -1,6 +1,6 @@ require_relative "test_helper" -xdescribe "max subarray" do +describe "max subarray" do it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do # Arrange input = [-2,1,-3,4,-1,2,1,-5,4]