From bf08e7cadd697af1aae630b2c2b24cfe58931313 Mon Sep 17 00:00:00 2001 From: Jocelyn Wang Date: Thu, 15 Oct 2020 14:39:13 -0700 Subject: [PATCH 1/2] newman_conway --- lib/max_subarray.rb | 4 +--- lib/newman_conway.rb | 23 +++++++++++++++++++---- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/lib/max_subarray.rb b/lib/max_subarray.rb index 5204edb..d91f34c 100644 --- a/lib/max_subarray.rb +++ b/lib/max_subarray.rb @@ -2,7 +2,5 @@ # Time Complexity: ? # Space Complexity: ? def max_sub_array(nums) - return 0 if nums == nil - - raise NotImplementedError, "Method not implemented yet!" + end diff --git a/lib/newman_conway.rb b/lib/newman_conway.rb index 4c985cd..dfb3adb 100644 --- a/lib/newman_conway.rb +++ b/lib/newman_conway.rb @@ -1,7 +1,22 @@ +# Time complexity: O(n) +# Space Complexity: O(n) +def newman_conway(num) + raise ArgumentError if num == 0 + array = [num, 0] + count = 1 + + until count > num + if count == 1 || count == 2 + array[count] = 1 + else + array[count] = array[array[count - 1]] + array[count - array[count - 1]] + end + + count += 1 + end -# Time complexity: ? -# Space Complexity: ? -def newman_conway(num) - raise NotImplementedError, "newman_conway isn't implemented" + p array[1..(array.length - 1)].join(' ') + + array[1..(array.length - 1)].join(' ') end \ No newline at end of file From bfe01154638b591070c97277b46d7d0e7f2f6fcb Mon Sep 17 00:00:00 2001 From: Jocelyn Wang Date: Thu, 15 Oct 2020 15:20:47 -0700 Subject: [PATCH 2/2] max_subarray --- lib/max_subarray.rb | 23 ++++++++++++++++++++--- test/max_sub_array_test.rb | 2 +- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/lib/max_subarray.rb b/lib/max_subarray.rb index d91f34c..52ed279 100644 --- a/lib/max_subarray.rb +++ b/lib/max_subarray.rb @@ -1,6 +1,23 @@ -# Time Complexity: ? -# Space Complexity: ? +# Time Complexity: O(n) +# Space Complexity: O(1) def max_sub_array(nums) - + return nums.inject(:+) if nums.length <= 3 + + max_so_far = nums[0] + max_ending_here = nums[0] + + nums.each do |num| + if max_ending_here < num + max_ending_here = num + elsif num < max_ending_here + max_ending_here += num + end + + if max_so_far < max_ending_here + max_so_far = max_ending_here + end + end + + return max_so_far end diff --git a/test/max_sub_array_test.rb b/test/max_sub_array_test.rb index 3253cdf..e27e1ca 100644 --- a/test/max_sub_array_test.rb +++ b/test/max_sub_array_test.rb @@ -1,6 +1,6 @@ require_relative "test_helper" -xdescribe "max subarray" do +describe "max subarray" do it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do # Arrange input = [-2,1,-3,4,-1,2,1,-5,4]