Space - Faezeh #19
Open
Space - Faezeh #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 2, 2020
Comment on lines
+19
to
21
| # Time Complexity: O(Log n) | ||
| # Space Complexity: O(1) | ||
| def add(key, value) |
There was a problem hiding this comment.
👍 , but the space complexity is O(log n) because of the call stack, assuming the tree is balanced.
Comment on lines
+45
to
47
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) | ||
| def find(key) |
There was a problem hiding this comment.
👍 , but the space complexity is O(log n) because of the call stack, assuming the tree is balanced.
Comment on lines
+75
to
77
| # Time Complexity: O(Log n) | ||
| # Space Complexity: O(n) | ||
| def inorder |
There was a problem hiding this comment.
👍 Since we hit each node in the list, the the time complexity is also O(n)
Comment on lines
+99
to
+105
| def inorder_helper(node, &block) | ||
| return if node.nil? | ||
|
|
||
| inorder_helper(node.left, &block) | ||
| yield node | ||
| inorder_helper(node.right, &block) | ||
| end |
Comment on lines
+107
to
109
| # Time Complexity: O(Log n) | ||
| # Space Complexity: O(n) | ||
| def preorder |
There was a problem hiding this comment.
The traversals are all O(n) in time complexity.
Comment on lines
+130
to
132
| # Time Complexity: O(Log n) | ||
| # Space Complexity: O(n) | ||
| def postorder |
Comment on lines
+153
to
155
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def height |
There was a problem hiding this comment.
⚠ This doesn't quite work as it goes down the left and right sides of the tree but doesn't investigate all paths to the leaves.
A better solution:
def height_helper(current_node)
return 0 if current_node.nil?
return 1 +[height_helper(current_node.left), height_helper(current_node.right)].max
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.