From b107161c9a1d8f2724c3fbe57b485f003e4ecf9c Mon Sep 17 00:00:00 2001 From: CheezItMan Date: Thu, 8 Aug 2019 14:52:50 -0700 Subject: [PATCH 1/4] added tests --- Rakefile | 10 ++++++++++ test/find_xml_test.rb | 11 +++++++++++ test/test_data/example.xml | 0 test/test_helper.rb | 13 +++++++++++++ 4 files changed, 34 insertions(+) create mode 100644 Rakefile create mode 100644 test/find_xml_test.rb create mode 100644 test/test_data/example.xml create mode 100644 test/test_helper.rb diff --git a/Rakefile b/Rakefile new file mode 100644 index 0000000..b5ea720 --- /dev/null +++ b/Rakefile @@ -0,0 +1,10 @@ +require 'rake/testtask' + +Rake::TestTask.new do |t| + t.libs = ["lib"] + t.warning = true + t.test_files = FileList['test/*_test.rb'] +end + +task default: :test + diff --git a/test/find_xml_test.rb b/test/find_xml_test.rb new file mode 100644 index 0000000..09af9d2 --- /dev/null +++ b/test/find_xml_test.rb @@ -0,0 +1,11 @@ +require_relative 'test_helper' + +describe "find_xml_file" do + it "should return nil if there are no xml files" do + expect(find_xml_file('.')).must_be_nil + end + + it "should return an xml file if it's in the folder" do + expect(find_xml_file('./test/test_data')).must_equal "example.xml" + end +end diff --git a/test/test_data/example.xml b/test/test_data/example.xml new file mode 100644 index 0000000..e69de29 diff --git a/test/test_helper.rb b/test/test_helper.rb new file mode 100644 index 0000000..04be228 --- /dev/null +++ b/test/test_helper.rb @@ -0,0 +1,13 @@ +require 'minitest' +require 'minitest/autorun' +require 'minitest/reporters' +require 'minitest/skip_dsl' +require 'awesome_print' +# Add simplecov + +Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new + +# Require_relative your lib files here! + +require_relative '../find_xml_file.rb' + From 6e7122b72eb177fa3f214372899ab9e45ab73ad8 Mon Sep 17 00:00:00 2001 From: CheezItMan Date: Thu, 8 Aug 2019 14:53:02 -0700 Subject: [PATCH 2/4] find_xml_file --- find_xml_file.rb | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 find_xml_file.rb diff --git a/find_xml_file.rb b/find_xml_file.rb new file mode 100644 index 0000000..f848fd3 --- /dev/null +++ b/find_xml_file.rb @@ -0,0 +1,15 @@ + +def find_xml_file(folder) + files = Dir.entries(folder) + + xml_file = nil + + files.each do |filename| + if filename.match "\.xml$" + xml_file = filename + break + end + end + + return xml_file +end From e7485dc82c94f8de3245385efb94027a87c9c459 Mon Sep 17 00:00:00 2001 From: simon Date: Thu, 12 Aug 2021 17:10:37 -0700 Subject: [PATCH 3/4] adds pycache to gitignore for python tests --- .gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..ba0430d --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +__pycache__/ \ No newline at end of file From f9452b41f23daa688cfb5d2fb328dd827db218ed Mon Sep 17 00:00:00 2001 From: simon Date: Thu, 12 Aug 2021 17:11:16 -0700 Subject: [PATCH 4/4] Rakefile->test.sh, rb tests->pytest --- Rakefile | 10 ---------- find_xml_file.rb | 15 --------------- .../example.xml => find_xml_file/__init__.py | 0 find_xml_file/find_xml_file.py | 14 ++++++++++++++ test.sh | 3 +++ test/find_xml_test.rb | 11 ----------- test/test_helper.rb | 13 ------------- tests/__init__.py | 0 tests/test_data/example.xml | 0 tests/test_find_xml_file.py | 10 ++++++++++ 10 files changed, 27 insertions(+), 49 deletions(-) delete mode 100644 Rakefile delete mode 100644 find_xml_file.rb rename test/test_data/example.xml => find_xml_file/__init__.py (100%) create mode 100644 find_xml_file/find_xml_file.py create mode 100644 test.sh delete mode 100644 test/find_xml_test.rb delete mode 100644 test/test_helper.rb create mode 100644 tests/__init__.py create mode 100644 tests/test_data/example.xml create mode 100644 tests/test_find_xml_file.py diff --git a/Rakefile b/Rakefile deleted file mode 100644 index b5ea720..0000000 --- a/Rakefile +++ /dev/null @@ -1,10 +0,0 @@ -require 'rake/testtask' - -Rake::TestTask.new do |t| - t.libs = ["lib"] - t.warning = true - t.test_files = FileList['test/*_test.rb'] -end - -task default: :test - diff --git a/find_xml_file.rb b/find_xml_file.rb deleted file mode 100644 index f848fd3..0000000 --- a/find_xml_file.rb +++ /dev/null @@ -1,15 +0,0 @@ - -def find_xml_file(folder) - files = Dir.entries(folder) - - xml_file = nil - - files.each do |filename| - if filename.match "\.xml$" - xml_file = filename - break - end - end - - return xml_file -end diff --git a/test/test_data/example.xml b/find_xml_file/__init__.py similarity index 100% rename from test/test_data/example.xml rename to find_xml_file/__init__.py diff --git a/find_xml_file/find_xml_file.py b/find_xml_file/find_xml_file.py new file mode 100644 index 0000000..70e304d --- /dev/null +++ b/find_xml_file/find_xml_file.py @@ -0,0 +1,14 @@ +import os + + +def find_xml_file(folder): + files = os.listdir(folder) + + xml_file = None + + for filename in files: + if filename.endswith(".xml"): + xml_file = filename + break + + return xml_file diff --git a/test.sh b/test.sh new file mode 100644 index 0000000..9cb31a3 --- /dev/null +++ b/test.sh @@ -0,0 +1,3 @@ +#!/bin/bash + +pytest \ No newline at end of file diff --git a/test/find_xml_test.rb b/test/find_xml_test.rb deleted file mode 100644 index 09af9d2..0000000 --- a/test/find_xml_test.rb +++ /dev/null @@ -1,11 +0,0 @@ -require_relative 'test_helper' - -describe "find_xml_file" do - it "should return nil if there are no xml files" do - expect(find_xml_file('.')).must_be_nil - end - - it "should return an xml file if it's in the folder" do - expect(find_xml_file('./test/test_data')).must_equal "example.xml" - end -end diff --git a/test/test_helper.rb b/test/test_helper.rb deleted file mode 100644 index 04be228..0000000 --- a/test/test_helper.rb +++ /dev/null @@ -1,13 +0,0 @@ -require 'minitest' -require 'minitest/autorun' -require 'minitest/reporters' -require 'minitest/skip_dsl' -require 'awesome_print' -# Add simplecov - -Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new - -# Require_relative your lib files here! - -require_relative '../find_xml_file.rb' - diff --git a/tests/__init__.py b/tests/__init__.py new file mode 100644 index 0000000..e69de29 diff --git a/tests/test_data/example.xml b/tests/test_data/example.xml new file mode 100644 index 0000000..e69de29 diff --git a/tests/test_find_xml_file.py b/tests/test_find_xml_file.py new file mode 100644 index 0000000..e39f4cd --- /dev/null +++ b/tests/test_find_xml_file.py @@ -0,0 +1,10 @@ +from find_xml_file.find_xml_file import find_xml_file + + +def test_no_files_returns_None(): + assert find_xml_file(".") is None + + +def test_finds_existing_xml_file(): + PATH_TO_TEST_XML = "./test/test_data" + assert find_xml_file(PATH_TO_TEST_XML) == "example.xml"