Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration tools (rustfmt, clippy) #50

Open
ralfbiedert opened this issue Jul 16, 2018 · 1 comment
Open

Collaboration tools (rustfmt, clippy) #50

ralfbiedert opened this issue Jul 16, 2018 · 1 comment

Comments

@ralfbiedert
Copy link
Contributor

After my last PR I noticed you had to clean up a bit. That made me wonder if it makes sense to configure and use clippy and rustfmt:

  • Since clippy is probably less controversial I went ahead and addressed all current issues, either by changing code (where I thought clippy made sense), or disabling lints (e.g., where faster bends rules for speed). Some of the more pedantic lints could be discussed, e.g., usage and formatting of number literals (unreadable_literal, unseparated_literal_suffix). https://github.com/ralfbiedert/faster/tree/clippy

  • I think rustfmt makes sense as well, but needs more configuration to resonate with the code. I found a few settings that worked for me (e.g., max_width be set rather high not to break up most macros which makes them harder to read). However you should probably take the lead on that one.

Let me know what you think about clippy, in particular unreadable_literal, unseparated_literal_suffix and type_complexity (I prefer the former 2, no opinion on 3rd). I can then create another PR.

@AdamNiederer
Copy link
Owner

Thanks, I've been meaning to get clippy and rustfmt working with faster. So far, I've just been doing whatever emacs decides to do. I'll try to integrate clippy into the CI once I get some time (apologies for the response latency and low contribution bandwidth; I've been super busy this past month)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants