Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support for parsing comment tag #1

Open
Adamska1008 opened this issue Aug 20, 2024 · 0 comments
Open

[Feature] Support for parsing comment tag #1

Adamska1008 opened this issue Aug 20, 2024 · 0 comments
Labels
feature New feature good first issue Good for newcomers

Comments

@Adamska1008
Copy link
Owner

Adamska1008 commented Aug 20, 2024

Background

Although comment tags do not affect the content of an XML document, parsing them is a standard feature in almost all XML parsers. Implementing this feature in myxml will ensure compatibility and completeness, making the library more robust.

Feature Description

  • In element.hpp: Create a Comment class as a subclass of the Node class. This class should have functionalities similar to the Text class, allowing comments to be treated as a specific type of node within the DOM.
  • In parser.hpp: There's no need to create a separate method specifically for parsing comment tags. Instead, enhance the Parser::parseTag method to recognize and handle comment tags. In Parser::ParseElement, when a comment tag is detected, it should be added as a child node of the current element.
@Adamska1008 Adamska1008 added good first issue Good for newcomers feature New feature labels Aug 20, 2024
@Adamska1008 Adamska1008 changed the title Parse Comment Tag [Feature] Support for parsing comment tag Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant