Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish a Complete Exception Handling Framework #6

Closed
Adamska1008 opened this issue Aug 26, 2024 · 0 comments · Fixed by #7
Closed

Establish a Complete Exception Handling Framework #6

Adamska1008 opened this issue Aug 26, 2024 · 0 comments · Fixed by #7
Assignees
@Adamska1008
Labels
feature New feature

Comments

@Adamska1008
Copy link
Owner

Currently the parser has NO proper error-handling mechanism. It only returns std::nullopt for any function where an error may occur.That is insane.

At least, we should define a basic exception class that covers all exceptions in parsing.
@Adamska1008 Adamska1008 added the feature New feature label Aug 26, 2024
@Adamska1008 Adamska1008 self-assigned this Aug 26, 2024
@Adamska1008 Adamska1008 linked a pull request Aug 28, 2024 that will close this issue
6 establish a complete exception handling framework #7
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adamska1008 Adamska1008

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

6 establish a complete exception handling framework Adamska1008/myxml
1 participant
@Adamska1008