Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari hard hangs on launch when AdGuard for Safari is installed and when you have many profiles in Safari #1024

Open
4 tasks done
ptorok opened this issue Oct 1, 2024 · 1 comment
Assignees

Comments

@ptorok
Copy link

ptorok commented Oct 1, 2024

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I made sure all content blockers are enabled in Safari settings
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

1.11.19

Environment

- OS: Sequoia 15.0 (also affected 14.x)
- Safari version: 18.0 (20619.1.26.31.6) (also affected 17.x)

What filters do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Install extension
  2. Launch Safari
  3. Note Safari hangs with beach ball indefinitely
  4. Force quit Safari and generate MacOS crash/hang log

Expected Behavior

Safari should launch normally and the extension should work

Actual Behavior

  • Safari hard hangs, with the spinning beach ball.
  • Force quitting Safari is the only way to regain control.
  • This is fully reproducible 100% of the time.
  • Uninstalling AdGuard for Safari immediately fixes the issue.
  • This started back around April with the previous versions of Safari, MacOS and AdGuard for Safari.
  • None of the updates have fixed it
  • Redacted MacOS crash log is attached.

Screenshots

Date/Time: 2024-10-01 12:38:51.621 +0200
End time: 2024-10-01 12:39:05.565 +0200
OS Version: macOS 15.0 (Build 24A335)
Architecture: arm64e
Report Version: 53

Command: Safari
Path: /Volumes/VOLUME/*/Safari.app/Contents/MacOS/Safari
Identifier: com.apple.Safari
Version: 18.0 (20619.1.26.31.6)
Build Version: 2
Project Name: Safari
Source Version: 7619001026031006
Is First Party: Yes
Architecture: arm64e
Parent: launchd [1]
PID: 33770
Time Since Fork: 14s

Event: hang
Duration: 13.94s
Duration Sampled: 1.60s (process was unresponsive for 12 seconds before sampling)
Steps: 16 (100ms sampling interval)

Hardware model: MacBookPro18,3
Active cpus: 10
HW page size: 16384
VM page size: 16384

Time Since Boot: 324627s
Time Awake Since Boot: 295963s
Time Since Wake: 12671s

Fan speed: 0 rpm
Total CPU Time: 2.646s (4.0G cycles, 6.4G instructions, 0.62c/i)
Advisory levels: Battery -> 3, User -> 2, ThermalPressure -> 0, Combined -> 2
Free disk space: 70.75 GB/926.35 GB, low space threshold 3072 MB
Vnodes Available: 74.73% (196671/263168)

Processes reached dispatch thread soft limit (64): Safari [33770]

Preferred User Language: en-GB
Country Code: GB
Keyboards: ABC
OS Cryptex File Extents: 209


Timeline format: stacks are sorted chronologically
Use -i and -heavy to re-report with count sorting

Heaviest stack for the main thread of the target process:
16 start + 2840 (dyld + 25204) [0x191214274]
16 SafariMain + 468 (Safari + 4787024) [0x1c2470b50]
16 NSApplicationMain + 888 (AppKit + 17484) [0x19518944c]
16 -[NSApplication run] + 480 (AppKit + 187260) [0x1951b2b7c]
16 -[BrowserApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 228 (Safari + 887244) [0x1c20b89cc]
16 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 688 (AppKit + 9832376) [0x195ae57b8]
16 _DPSNextEvent + 660 (AppKit + 240240) [0x1951bfa70]
16 _BlockUntilNextEventMatchingListInModeWithFilter + 76 (HIToolbox + 1122336) [0x19caba020]
16 ReceiveNextEventCommon + 636 (HIToolbox + 1121980) [0x19cab9ebc]
16 RunCurrentEventLoopInMode + 292 (HIToolbox + 1097932) [0x19cab40cc]
16 CFRunLoopRunSpecific + 572 (CoreFoundation + 508724) [0x19167c334]
16 __CFRunLoopRun + 1996 (CoreFoundation + 512380) [0x19167d17c]
16 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE + 16 (CoreFoundation + 775808) [0x1916bd680]
16 _dispatch_main_queue_callback_4CF + 44 (libdispatch.dylib + 76676) [0x1913f2b84]
16 _dispatch_main_queue_drain + 980 (libdispatch.dylib + 77672) [0x1913f2f68]
16 _dispatch_client_callout + 20 (libdispatch.dylib + 18008) [0x1913e4658]
16 _dispatch_call_block_and_release + 32 (libdispatch.dylib + 10488) [0x1913e28f8]
16 __59-[WBSExtensionsController loadSuitableDiscoveredExtensions]_block_invoke + 60 (SafariSharedUI + 118424) [0x1d1802e98]
16 -[WBSExtensionsController _loadExtensions:skipEqualityCheck:] + 1052 (SafariSharedUI + 123164) [0x1d180411c]
16 -[WBSExtensionsController _validateAndLoadExtensionIfNecessary:attemptRetryOnFailure:isExtensionNewlyInstalled:] + 264 (SafariSharedUI + 124620) [0x1d18046cc]
16 -[SafariExtensionsController _computeCodeSigningDictionaryOnDiskForExtension:attemptRetryOnFailure:] + 16 (Safari + 4770932) [0x1c246cc74]
16 -[WBSExtensionsController(SafariExtras) safari_computeCodeSigningDictionaryOnDiskIfNecessaryForExtension:attemptRetryOnFailure:] + 268 (Safari + 4979100) [0x1c249f99c]
16 -[NSExtension(SafariServicesExtras) sf_untrustedCodeSigningDictionaryFromCodeRef:enforcingCodeSigningRequirement:skipValidityCheck:failedCodeSigningRequirements:] + 748 (SafariServices + 60884) [0x1b8921dd4]
16 SecStaticCodeCheckValidityWithErrors + 228 (Security + 2065716) [0x1947ff534]
16 Security::CodeSigning::SecStaticCode::staticValidate(unsigned int, Security::CodeSigning::SecRequirement const*) + 2424 (Security + 2112756) [0x19480acf4]
16 Security::Dispatch::Group::wait() + 36 (Security + 3264012) [0x194923e0c]
16 _dispatch_group_wait_slow + 56 (libdispatch.dylib + 21528) [0x1913e5418]
16 __ulock_wait + 8 (libsystem_kernel.dylib + 11148) [0x191557b8c]
*16 ??? (kernel.release.t6000 + 6143940) [0xfffffe0008cf3fc4]

Process: Safari [33770]
Path: /Volumes/VOLUME/*/Safari.app/Contents/MacOS/Safari
Identifier: com.apple.Safari
Version: 18.0 (20619.1.26.31.6)
Build Version: 2
Project Name: Safari
Source Version: 7619001026031006
Is First Party: Yes
Architecture: arm64e
Parent: launchd [1]
UID: 501
Footprint: 157.35 MB
Time Since Fork: 14s
Num samples: 16 (1-16)
CPU Time: 0.023s (26.3M cycles, 17.1M instructions, 1.54c/i)
Note: Unresponsive for 12 seconds before sampling
Num threads: 100
Note: 4 idle work queue threads omitted
Dispatch Thread Soft Limit Reached: 64 (too many dispatch threads blocked in synchronous operations)

Thread 0x2d6eaa DispatchQueue "com.apple.main-thread"(1) 16 samples (1-16) priority 47 (base 47)
<process frontmost, thread QoS user interactive (requested user interactive), process unclamped, process received importance donation from WindowServer [425], process received importance donation from distnoted [630], process received importance donation from ViewBridgeAuxiliary [722], process received importance donation from CursorUIViewService [756], IO tier 0>
16 start + 2840 (dyld + 25204) [0x191214274] 1-16
16 SafariMain + 468 (Safari + 4787024) [0x1c2470b50] 1-16
16 NSApplicationMain + 888 (AppKit + 17484) [0x19518944c] 1-16
16 -[NSApplication run] + 480 (AppKit + 187260) [0x1951b2b7c] 1-16
16 -[BrowserApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 228 (Safari + 887244) [0x1c20b89cc] 1-16
16 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 688 (AppKit + 9832376) [0x195ae57b8] 1-16
16 _DPSNextEvent + 660 (AppKit + 240240) [0x1951bfa70] 1-16
16 _BlockUntilNextEventMatchingListInModeWithFilter + 76 (HIToolbox + 1122336) [0x19caba020] 1-16
16 ReceiveNextEventCommon + 636 (HIToolbox + 1121980) [0x19cab9ebc] 1-16
16 RunCurrentEventLoopInMode + 292 (HIToolbox + 1097932) [0x19cab40cc] 1-16
16 CFRunLoopRunSpecific + 572 (CoreFoundation + 508724) [0x19167c334] 1-16
16 __CFRunLoopRun + 1996 (CoreFoundation + 512380) [0x19167d17c] 1-16
16 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE + 16 (CoreFoundation + 775808) [0x1916bd680] 1-16
16 _dispatch_main_queue_callback_4CF + 44 (libdispatch.dylib + 76676) [0x1913f2b84] 1-16
16 _dispatch_main_queue_drain + 980 (libdispatch.dylib + 77672) [0x1913f2f68] 1-16
16 _dispatch_client_callout + 20 (libdispatch.dylib + 18008) [0x1913e4658] 1-16
16 _dispatch_call_block_and_release + 32 (libdispatch.dylib + 10488) [0x1913e28f8] 1-16
16 __59-[WBSExtensionsController loadSuitableDiscoveredExtensions]_block_invoke + 60 (SafariSharedUI + 118424) [0x1d1802e98] 1-16
16 -[WBSExtensionsController _loadExtensions:skipEqualityCheck:] + 1052 (SafariSharedUI + 123164) [0x1d180411c] 1-16
16 -[WBSExtensionsController _validateAndLoadExtensionIfNecessary:attemptRetryOnFailure:isExtensionNewlyInstalled:] + 264 (SafariSharedUI + 124620) [0x1d18046cc] 1-16
16 -[SafariExtensionsController _computeCodeSigningDictionaryOnDiskForExtension:attemptRetryOnFailure:] + 16 (Safari + 4770932) [0x1c246cc74] 1-16
16 -[WBSExtensionsController(SafariExtras) safari_computeCodeSigningDictionaryOnDiskIfNecessaryForExtension:attemptRetryOnFailure:] + 268 (Safari + 4979100) [0x1c249f99c] 1-16
16 -[NSExtension(SafariServicesExtras) sf_untrustedCodeSigningDictionaryFromCodeRef:enforcingCodeSigningRequirement:skipValidityCheck:failedCodeSigningRequirements:] + 748 (SafariServices + 60884) [0x1b8921dd4] 1-16
16 SecStaticCodeCheckValidityWithErrors + 228 (Security + 2065716) [0x1947ff534] 1-16
16 Security::CodeSigning::SecStaticCode::staticValidate(unsigned int, Security::CodeSigning::SecRequirement const*) + 2424 (Security + 2112756) [0x19480acf4] 1-16
16 Security::Dispatch::Group::wait() + 36 (Security + 3264012) [0x194923e0c] 1-16
16 _dispatch_group_wait_slow + 56 (libdispatch.dylib + 21528) [0x1913e5418] 1-16
16 __ulock_wait + 8 (libsystem_kernel.dylib + 11148) [0x191557b8c] 1-16
*16 ??? (kernel.release.t6000 + 6143940) [0xfffffe0008cf3fc4] 1-16

[... other threads omitted ...]

Process: AdGuardForSafariBlockerExtension (AdGuardForSafariBlockerExtension) [33798] (suspended)
UUID: 3BD63251-94DB-32C1-8B20-17ED50215683
Path: /Applications/AdGuard for Safari.app/Contents/PlugIns/AdGuardForSafariBlockerExtension.appex/Contents/MacOS/AdGuardForSafariBlockerExtension
Identifier: com.adguard.safari.AdGuard.BlockerExtension
Version: 1.11.19 (335)
Team ID: TC3Q7MAJXF
Shared Cache: D997B0E9-E31B-35FE-B129-3171B279B087 slid base address 0x191148000, slide 0x11148000 (System Primary)
Architecture: arm64
Parent: launchd [1]
Responsible: Safari [33770]
UID: 501
Footprint: 4353 KB
Time Since Fork: 14s
Num samples: 16 (1-16)
Note: Suspended for 16 samples
Num threads: 4
Note: 2 idle work queue threads omitted

Thread 0x2d6fda DispatchQueue "com.apple.main-thread"(1) 16 samples (1-16) priority 4 (base 4)
<thread QoS background (requested default), thread darwinbg, process darwinbg, IO tier 2>
16 start + 2840 (dyld + 25204) [0x191214274] 1-16
16 NSExtensionMain + 204 (Foundation + 868796) [0x1928b41bc] 1-16
16 EXExtensionMain + 304 (ExtensionFoundation + 107560) [0x1ee5f3428] 1-16
16 ??? (PlugInKit + 120828) [0x1a08077fc] 1-16
16 ??? (PlugInKit + 118536) [0x1a0806f08] 1-16
16 ??? (PlugInKit + 119452) [0x1a080729c] 1-16
16 ??? (PlugInKit + 119852) [0x1a080742c] 1-16
16 -[NSXPCListener resume] + 308 (Foundation + 497376) [0x1928596e0] 1-16
16 xpc_main + 64 (libxpc.dylib + 103204) [0x1912ae324] 1-16
16 _xpc_main + 276 (libxpc.dylib + 170132) [0x1912be894] 1-16
16 _xpc_objc_main + 700 (libxpc.dylib + 104328) [0x1912ae788] 1-16
16 -[NSRunLoop(NSRunLoop) run] + 64 (Foundation + 860052) [0x1928b1f94] 1-16
16 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 212 (Foundation + 370184) [0x19283a608] 1-16
16 CFRunLoopRunSpecific + 572 (CoreFoundation + 508724) [0x19167c334] 1-16
16 __CFRunLoopRun + 1212 (CoreFoundation + 511596) [0x19167ce6c] 1-16
16 __CFRunLoopServiceMachPort + 160 (CoreFoundation + 517564) [0x19167e5bc] 1-16
16 mach_msg + 24 (libsystem_kernel.dylib + 4476) [0x19155617c] 1-16
16 mach_msg_overwrite + 480 (libsystem_kernel.dylib + 39384) [0x19155e9d8] 1-16
16 mach_msg2_trap + 8 (libsystem_kernel.dylib + 3636) [0x191555e34] 1-16
*16 ??? (kernel.release.t6000 + 242344) [0xfffffe00087532a8] (suspended) 1-16

Thread 0x2d7178 16 samples (1-16) priority 4 (base 4)
<thread QoS background (requested default), thread darwinbg, process darwinbg, IO tier 2>
16 start_wqthread + 0 (libsystem_pthread.dylib + 8424) [0x1915920e8] 1-16
*16 ??? (kernel.release.t6000 + 796368) [0xfffffe00087da6d0] (suspended) 1-16

Binary Images:
0x100978000 - ??? com.adguard.safari.AdGuard.BlockerExtension 1.11.19 (335) <3BD63251-94DB-32C1-8B20-17ED50215683> /Applications/AdGuard for Safari.app/Contents/PlugIns/AdGuardForSafariBlockerExtension.appex/Contents/MacOS/AdGuardForSafariBlockerExtension
0x19120e000 - 0x191290663 dyld (1231.3) <02E3CA05-E849-31C8-A4F2-C7292420DFAD> /usr/lib/dyld
0x191295000 - 0x1912dffff libxpc.dylib (2866.1.1) /usr/lib/system/libxpc.dylib
0x191555000 - 0x19158fff7 libsystem_kernel.dylib (11215.1.10) <9A72FD37-D827-3D6D-B6F4-422621E36C94> /usr/lib/system/libsystem_kernel.dylib
0x191590000 - 0x19159cfff libsystem_pthread.dylib (535) /usr/lib/system/libsystem_pthread.dylib
0x191600000 - 0x191af6fff com.apple.CoreFoundation 6.9 (3038.1.402) <90EB8FD1-925E-38EB-A056-EB4253B6A29E> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
0x1927e0000 - 0x19362dfff com.apple.Foundation 6.9 (3038.1.402) /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
0x1a07ea000 - 0x1a082afff com.apple.pluginkit.framework 1.0 (1) /System/Library/PrivateFrameworks/PlugInKit.framework/Versions/A/PlugInKit
0x1ee5d9000 - 0x1ee6a3fff com.apple.ExtensionFoundation 97 (97) <9BFC49F6-D19F-383F-B159-55ECD06C63F2> /System/Library/Frameworks/ExtensionFoundation.framework/Versions/A/ExtensionFoundation
*0xfffffe0008718000 - 0xfffffe0008febfff kernel.release.t6000 (11215.1.10) <3BD63A8A-A8AF-3B6F-B7D1-090482E1FBF4>__TEXT_EXEC /System/Library/Kernels/kernel.release.t6000

[... rest of file omitted ...]

Additional Information

This issue is a few months old and forced me to uninstall AdGuard after many years of use.
I have been unable to find a cause and no updates over the last few months have made any difference.
My Safari environment is only slightly unusual in that I have a long Reading List (1-2k items) and 25 Safari Profiles.

@4brunu
Copy link

4brunu commented Oct 2, 2024

I think I have the same issue, but I'm not sure if it's exactly the same.
When my MacBook sleeps and wakes up again, safari will become irresponsive and I need to force quick.
If I disable adguard, the issue disappears.

@adguard-bot adguard-bot assigned maximtop and unassigned alexx7311 Oct 8, 2024
@alexx7311 alexx7311 changed the title Safari hard hangs on launch when AdGuard for Safari is installed. Only removal of AdGuard allows Safari to work again. Safari hard hangs on launch when AdGuard for Safari is installed and when you have many profiles in Safari Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants