Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gen 5] Wild beta branch missing delay of 1 for Special Grass Encounter #421

Open
SexyMalasada opened this issue Sep 2, 2024 · 4 comments

Comments

@SexyMalasada
Copy link

SexyMalasada commented Sep 2, 2024

Hello

I noticed today that in the Beta Gen5 Wild branch of PokéFinder, when searching for Special Grass encounters, it does not account for the delay of 1 that these encounters have vs normal grass encounters.
As an example for comparison, I give the generator tab of PF and Generator of RNG Reporter for the same profile and seed.
image
image
This isn't that urgent or important to fix ASAP, but just thought I'd mention! However the next issue definitely is!

Lmk if you need anything else, and hope you can address this!

@Real96
Copy link
Collaborator

Real96 commented Sep 10, 2024

As a separate (but kinda related issue?) I wanted to test to see if this happened for the Surfing and Fishing options too, and to my surprise, it appears that clicking the 'Generate' button when using either Special Surfing or Special Fishing Encounter types in the Generator tab, will simply crash the program!

Lmk if you need anything else, and hope you can address these!

Separate the issues

@SexyMalasada SexyMalasada changed the title [Gen 5] Wild beta branch missing delay of 1 for Special Grass Encounter / Special Surfing & Fish encounter in the Generator crashes the program [Gen 5] Wild beta branch missing delay of 1 for Special Grass Encounter Sep 14, 2024
@SexyMalasada
Copy link
Author

As a separate (but kinda related issue?) I wanted to test to see if this happened for the Surfing and Fishing options too, and to my surprise, it appears that clicking the 'Generate' button when using either Special Surfing or Special Fishing Encounter types in the Generator tab, will simply crash the program!
Lmk if you need anything else, and hope you can address these!

Separate the issues

Done!

@Real96
Copy link
Collaborator

Real96 commented Oct 21, 2024

Related to this issue, doesn't simply putting 1 in the Delay box (which is now called Offset in latest commit) fix the problem?

@SexyMalasada
Copy link
Author

Related to this issue, doesn't simply putting 1 in the Delay box (which is now called Offset in latest commit) fix the problem?

Hiya!

I guess it would, but it would probably be more 'clean' to have the program assume that 1 delay for these encounter by default - assuming it's something easy for you guys to implement ofc!
If it's not, or until then, using the Offset box works yea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants