Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bnd-resolver-maven-plugin to check runtime compatibility with multiple AEM versions #2320

Open
kwin opened this issue May 29, 2020 · 6 comments
Labels

Comments

@kwin
Copy link
Contributor

kwin commented May 29, 2020

As there were recently some issues with compatibility in different versions of AEM (e.g. #2298) I suggest to use https://github.com/bndtools/bnd/tree/master/maven/bnd-resolver-maven-plugin to check the bundle constraints against multiple OSGi containers (lowest supported AEM version and newest supported AEM version).

A similar check has been implemented recently in apache/jackrabbit-filevault@b8e952d.

That way the build will fail if the acs-aem-commons bundles cannot be resolved in one of those containers. It still needs to be checked if the uber-jars can be used for that check....

@kwin
Copy link
Contributor Author

kwin commented May 29, 2020

At least the relevant provide-capability headers seem to be missing from https://repo1.maven.org/maven2/com/adobe/aem/aem-sdk-api/

@joerghoh
Copy link
Contributor

To address the same problem I would rather try to build against multiple versions of the uber.jar (6.4,6.5, AEMaaCS) with Travis.
My impression is that right now we cannot rely solely on OSGI metadata.

@kwin
Copy link
Contributor Author

kwin commented May 31, 2020

We have to distinguish between compile time resolution failure and run time resolution failure. In some cases although at compile time everything is correct a bundle still cannot be resolved in certain AEM versions at run time. Therefore I would really like to introduce this additional OSGi resolver check.

@stale
Copy link

stale bot commented Aug 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 1, 2020
@kwin kwin pinned this issue Aug 1, 2020
@stale stale bot removed the wontfix label Aug 1, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 4, 2020
@stale stale bot closed this as completed Oct 12, 2020
@kwin
Copy link
Contributor Author

kwin commented Nov 9, 2020

I opened https://issues.apache.org/jira/browse/SLING-9883 to include the necessary manifest headers in future AEM API jars.

@kwin kwin reopened this Nov 9, 2020
@stale stale bot removed the wontfix label Nov 9, 2020
@kwin kwin added the pinned label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants