Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Root Provider Fallback for Experience Fragments #3360

Open
HitmanInWis opened this issue Jun 13, 2024 · 0 comments
Open

Page Root Provider Fallback for Experience Fragments #3360

HitmanInWis opened this issue Jun 13, 2024 · 0 comments

Comments

@HitmanInWis
Copy link
Contributor

The original PageRootProvider was written before Experience Fragments were prominent. When the PageRootProvider attempts to get a root page for an Experience Fragment, it cannot find it. This leads to the following downsides:

  • Shared Component Properties render from the XF folder root rather than the rendered site. They are also stored there when authoring XF. This creates duplicate, potentially differing values from component instances in the site page tree and component instances within XF.
  • Contextual Pathbrowser (from ACS AEM Commons) cannot be effectively used in components with XF, as the page root cannot be determined.
  • Any other site functionality that wants to get the site homepage is unable to do so reliably with PageRootProvider

We should update the current PageRootProvider to check for a fallbackPageRoot property in the resource inherited properties. This would allow a property of fallbackPageRoot="/content/mysite/en" in the folder root of XF, which would then cause all uses of PageRootProvider to return the website homepage.

Since this would only work in cases where the XF folder defines the property, it would be backward compatible with legacy implementations. It would just give a new option for people that want their site to store/use Shared Component Properties and get the "homepage" using PageRootProvider from their site directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant