Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make desktop-helper-sample safer #60

Open
JeffWinder opened this issue Dec 10, 2021 · 0 comments
Open

Make desktop-helper-sample safer #60

JeffWinder opened this issue Dec 10, 2021 · 0 comments

Comments

@JeffWinder
Copy link
Contributor

In desktop-helper-sample electron's main file electron.js has nodeIntegration set to true. This is considered unsafe and not necessary to run this sample.
See also Electron docs

More secure would be:

webPreferences: {
        nodeIntegration: false,
        contextIsolation: true,
    },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeffWinder