Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPT-8] Enable sharing link to a specific mentor #522

Closed
wei2912 opened this issue Sep 24, 2022 · 3 comments · May be fixed by #554
Closed

[MPT-8] Enable sharing link to a specific mentor #522

wei2912 opened this issue Sep 24, 2022 · 3 comments · May be fixed by #554
Labels
Feature Created by Linear-GitHub Sync linear
Milestone
v.19

Comments

@wei2912
Copy link
Member

wei2912 commented Sep 24, 2022 •
edited
Loading

See title.

MPT-8
@wei2912
Copy link
Member Author

wei2912 commented Dec 30, 2022

On hold till #559 is over.

@wei2912 wei2912 changed the title Enable sharing link to a specific mentor [MPT-8] Enable sharing link to a specific mentor May 13, 2023
@wei2912 wei2912 removed this from the 2023 Wave milestone May 13, 2023
@wei2912 wei2912 added the Feature Created by Linear-GitHub Sync label May 13, 2023
@wei2912 wei2912 self-assigned this May 28, 2023
@wei2912 wei2912 added this to the v.3 milestone Jun 8, 2023
@wei2912 wei2912 removed their assignment Jun 11, 2023
@wei2912 wei2912 modified the milestones: v.3, v.5 Jul 6, 2023
@wei2912 wei2912 assigned yashchellani and unassigned soloplxya Jul 16, 2023
@wei2912 wei2912 linked a pull request Jul 16, 2023 that will close this issue
[MPT-8] Link sharing enhancement #554
Draft
@wei2912 wei2912 assigned yashchellani and unassigned yashchellani Jul 16, 2023
@wei2912 wei2912 modified the milestones: v.5, v.6 Jul 23, 2023
@wei2912 wei2912 modified the milestones: v.6, v.7 Aug 6, 2023
@wei2912
Copy link
Member Author

wei2912 commented Aug 20, 2023

Please reach out to @soloplxya for discussion on past code and adapting to NextJS!

@wei2912 wei2912 modified the milestones: v.7, v.9 Sep 3, 2023
@wei2912 wei2912 modified the milestones: v.9, v.10 Sep 17, 2023
@wei2912 wei2912 assigned yashchellani and unassigned yashchellani Oct 22, 2023
@wei2912 wei2912 modified the milestones: v.10, v.14 Nov 12, 2023
@wei2912 wei2912 modified the milestones: v.14, v.16 Dec 10, 2023
@wei2912 wei2912 modified the milestones: v.16, v.17 Dec 24, 2023
@wei2912 wei2912 modified the milestones: v.17, MPT 2024 Mentorship Wave Jan 6, 2024
@wei2912
Copy link
Member Author

wei2912 commented Feb 4, 2024

To work on routing (e.g. opening "Zheng Wei Chan" at /mentors/0/zheng-wei-chan, though in practice we will want to use a unique ID instead, say from ElasticSearch), so that upon opening a modal one can share the link at the top which will direct them straight to the modal.

Sharing button should be in a separate PR, @jcc-kh to create a new issue.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Created by Linear-GitHub Sync linear
Projects
Mentorship Platform Team (MPT)
Status: Todo
Milestone
v.19
Development

Successfully merging a pull request may close this issue.

[MPT-8] Link sharing enhancement AdvisorySG/mentorship-page
4 participants
@wei2912 @yashchellani @soloplxya @jcc-kh