Slow POS payments cause proxy timeout

[pmzandbergen]

Already working on a fix, please await the PR

Describe the bug
When initiating a POS payment using one of the following endpoints:

• /V1/adyen/orders/guest-carts/:cartId/pos-payment
• /V1/adyen/orders/carts/mine/pos-payment

The browser might receive a timeout if the POS payment takes a bit of time and the webserver (or proxy) is configured with a reasonable (shorter) timeout period. Cloudflare for example has a timeout of 100 seconds, a value which only can modified when using one of the Enterprise plans. This could be fixed using some kind of polling mechanism. Actually the frontend code already seems to include logic for this purpose:

adyen-magento2/view/frontend/web/js/view/payment/method-renderer/adyen-pos-cloud-method.js

Line 116 in cacef78

if (response.responseText.indexOf("In Progress") > -1) {

When the browser encounters a (proxy) timeout the response will generally not include "In Progress" and this solution is also not working out-of-the-box for PWA's.

To Reproduce
Steps to reproduce the behavior:

1. Ensure the webserver or proxy is configured with a timeout of, for example, 60 seconds
2. Start a POS / terminal payment
3. Wait for a minute before finishing the payment
4. See error

Expected behavior
The payment should be polled as long as the POS payment status isn't final.

Magento version
2.4.7-p3

Plugin version
Tested on 9.6.0, the logic is the same at the current version (9.14.0).

Screenshots

Desktop (please complete the following information):

• OS: MacOS
• Browser: Firefox
• Version: 134.0.2

Smartphone (please complete the following information):
N/A

Additional context
N/A

[pmzandbergen]

There is a config path for timeouts: payment/adyen_pos_cloud/total_timeout (default 120). This path currently isn't available at the Magento backend.

Testing how things are handled if configured.

[pmzandbergen]

Lowering this timeout (10 seconds for testing) leads to an internal server error:

Adyen\ConnectionException: Could not connect to Adyen (https://terminal-api-test.adyen.com/sync).  Please check your internet connection and try again. in [...]/vendor/adyen/php-api-library/src/Adyen/HttpClient/CurlClient.php:203

Frontend receives the following response:

{"message":"Internal Error. Details are available in Magento log file. Report ID: webapi-[...]"}

Conclusion: Lowering the configured timeout alone will not resolve this issue. Digging in the code seems that we are using the sync API:

adyen-magento2/Gateway/Http/Client/TransactionPosCloudSync.php

Line 65 in cacef78

$response = $service->runTenderSync($request);

We probably should use the async instead:
https://docs.adyen.com/api-explorer/terminal-api/latest/overview

Working on a patch.

[pmzandbergen]

It seems the POS implementation in the Adyen Magento module does not follow the guidelines as documented by Adyen:

https://docs.adyen.com/point-of-sale/design-your-integration/choose-your-architecture/cloud/

• The default timeout value is 120 seconds, where the documentation states it should be (at least) 150 seconds to guarantee a response for sync requests:
  • https://docs.adyen.com/point-of-sale/design-your-integration/choose-your-architecture/cloud/#build-payment-flow

  • This request must use an extended time-out of more than 150 seconds. During this time the connection is kept alive and a synchronous response will follow.

• Network issues are not being handled:
• https://docs.adyen.com/point-of-sale/design-your-integration/choose-your-architecture/cloud/#handle-network-issues

• To make your integration more resilient in case of connection issues, your integration should automatically make a transaction status request when it does not receive a payment response from Adyen.

[pmzandbergen]

Encountered a bug during testing:

adyen-magento2/Gateway/Request/PosCloudBuilder.php

Line 68 in cacef78

$serviceID = date("dHis");

The ServiceID used in POS Cloud API requests is a timestamp. If multiple requests are created in the same second, you will get an error. I'll change this to a more unique value.