TerminalCloudAPI async response type

[naseemkullah]

adyen-node-api-library/src/__mocks__/terminalApi/async.ts

Line 20 in 2a4c78b

export const asyncRes = "ok";

While happy path does return an "ok" string, it would appear that failed requests return a payload. Could you please confirm this and adjust the return type accordingly? Thank you!

[Kwok-he-Chu]

When calling the TerminalCloudApi (https://github.com/Adyen/adyen-node-api-library/blob/v23.3.0/src/services/terminalCloudAPI.ts#L55-L58) /async-endpoint, the returned response should be of type string

Could you provide a minimal example of the TerminalAPIRequest that you're trying to send, so that we can reproduce it?

[naseemkullah]

This response from /async endpoint has been observed when response is not ok (truncated)

[Kwok-he-Chu]

Would the following work for you:

Serialize the string to a terminalApiResponse, if the response is not ok?

[naseemkullah]

its fine as is, but what would be good is if the SDK just mentioned the response type could be "ok" | WhateverThisTypeIs so we know what to expect. this issue is raised mainly to correct the return type in the SDK, rather than change any behaviour.

[Kwok-he-Chu]

That makes sense. Thank you for the feedback.

[naseemkullah]

np! seems like its SaleToPOIRequest though you probably know that already :)

heres what it looks like devex wise