diff --git a/.baseline-phan.php b/.baseline-phan.php index 472fb6c..6a84cf2 100644 --- a/.baseline-phan.php +++ b/.baseline-phan.php @@ -11,13 +11,13 @@ // # Issue statistics: // PhanDeprecatedFunction : 20+ occurrences // PhanUndeclaredMethod : 15+ occurrences + // PhanParamSignatureMismatch : 10+ occurrences // PhanTypeMismatchReturn : 10+ occurrences // PhanUnreferencedClosure : 9 occurrences // PhanTypeMismatchArgument : 8 occurrences // PhanUndeclaredProperty : 8 occurrences // PhanTypeMismatchDeclaredReturn : 6 occurrences // PhanUnreferencedProtectedMethod : 6 occurrences - // PhanParamSignatureMismatch : 4 occurrences // PhanTypeMismatchArgumentSuperType : 4 occurrences // PhanTypeMismatchReturnSuperType : 4 occurrences // PhanTypeMismatchArgumentNullable : 3 occurrences @@ -25,17 +25,17 @@ // PhanWriteOnlyPrivateProperty : 3 occurrences // PhanTypeArraySuspicious : 2 occurrences // PhanTypeMismatchDimAssignment : 2 occurrences - // PhanTypeMismatchPropertyReal : 2 occurrences // PhanUndeclaredTypeParameter : 2 occurrences // PhanUnusedVariable : 2 occurrences // ConstReferenceClassNotImported : 1 occurrence + // PhanAccessClassInternal : 1 occurrence // PhanCompatiblePHP7 : 1 occurrence // PhanPossiblyNullTypeMismatchProperty : 1 occurrence // PhanReadOnlyPrivateProperty : 1 occurrence // PhanTypeInvalidLeftOperandOfNumericOp : 1 occurrence // PhanTypeMismatchArgumentInternal : 1 occurrence // PhanTypeMismatchArgumentReal : 1 occurrence - // PhanTypeMismatchDimFetch : 1 occurrence + // PhanTypeMismatchPropertyReal : 1 occurrence // PhanTypeMismatchReturnNullable : 1 occurrence // PhanUnextractableAnnotationElementName : 1 occurrence // PhanUnextractableAnnotationSuffix : 1 occurrence @@ -47,15 +47,16 @@ // Currently, file_suppressions and directory_suppressions are the only supported suppressions 'file_suppressions' => [ 'src/DependencyInjection/Configuration.php' => ['PhanDeprecatedFunction', 'PhanUndeclaredMethod', 'PhanUnreferencedClosure', 'PhanUnusedVariable'], - 'src/DependencyInjection/SHQFeaturesExtension.php' => ['PhanUnreferencedClass'], + 'src/DependencyInjection/SHQFeaturesExtension.php' => ['PhanAccessClassInternal', 'PhanUnreferencedClass'], 'src/Form/DataTransformer/AbstractFeatureTransformer.php' => ['PhanDeprecatedFunction'], - 'src/Form/DataTransformer/BooleanFeatureTransformer.php' => ['PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod'], - 'src/Form/DataTransformer/CountableFeatureTransformer.php' => ['PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod'], - 'src/Form/DataTransformer/RechargeableFeatureTransformer.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod', 'PhanUnusedPublicFinalMethodParameter'], + 'src/Form/DataTransformer/BooleanFeatureTransformer.php' => ['PhanParamSignatureMismatch', 'PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod'], + 'src/Form/DataTransformer/CountableFeatureTransformer.php' => ['PhanParamSignatureMismatch', 'PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod'], + 'src/Form/DataTransformer/FeaturesCollectionTransformer.php' => ['PhanParamSignatureMismatch'], + 'src/Form/DataTransformer/RechargeableFeatureTransformer.php' => ['PhanParamSignatureMismatch', 'PhanTypeMismatchArgument', 'PhanTypeMismatchReturnSuperType', 'PhanUndeclaredMethod', 'PhanUnusedPublicFinalMethodParameter'], 'src/Form/Type/FeaturesType.php' => ['PhanTypeMismatchArgumentSuperType', 'PhanUndeclaredMethod', 'PhanUnreferencedClosure'], 'src/InvoiceDrawer/AbstractInvoiceDrawer.php' => ['PhanWriteOnlyPublicProperty'], 'src/Manager/FeaturesManager.php' => ['PhanDeprecatedFunction', 'PhanUndeclaredMethod'], - 'src/Manager/InvoicesManager.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchDimFetch', 'PhanTypeMismatchPropertyReal', 'PhanUndeclaredMethod', 'PhanWriteOnlyPrivateProperty'], + 'src/Manager/InvoicesManager.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentNullable', 'PhanUndeclaredMethod', 'PhanWriteOnlyPrivateProperty'], 'src/Model/Feature/AbstractFeaturesCollection.php' => ['PhanDeprecatedFunction', 'PhanUnreferencedClosure', 'PhanUnreferencedPublicClassConstant'], 'src/Model/Feature/Configured/ConfiguredCountableFeature.php' => ['PhanReadOnlyPrivateProperty', 'PhanUnusedPublicFinalMethodParameter'], 'src/Model/Feature/Configured/ConfiguredFeaturesCollection.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchDeclaredReturn', 'PhanUnreferencedProtectedMethod'], diff --git a/.baseline-psalm.xml b/.baseline-psalm.xml index 1fa3023..3226286 100644 --- a/.baseline-psalm.xml +++ b/.baseline-psalm.xml @@ -1,5 +1,5 @@ - + @@ -28,6 +28,11 @@ + + + + + @@ -37,6 +42,10 @@ + + + + @@ -50,6 +59,10 @@ + + + + @@ -60,6 +73,10 @@ + + + + @@ -73,6 +90,10 @@ + + + + @@ -173,9 +194,6 @@ - - - @@ -377,7 +395,7 @@ - + diff --git a/composer.json b/composer.json index 00d33c0..3f391e1 100644 --- a/composer.json +++ b/composer.json @@ -35,7 +35,7 @@ "phpstan/phpstan-doctrine": "1.5.3", "phpstan/phpstan-phpunit": "1.4.0", "phpstan/phpstan-symfony": "1.4.10", - "rector/rector": "1.2.5", + "rector/rector": "1.2.6", "roave/security-advisories": "dev-master", "serendipity_hq/component-text-matrix": "^3.0", "serendipity_hq/rector-config": "^1.0",