Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trains again #84

Open
Nexela opened this issue May 21, 2017 · 2 comments
Open

Trains again #84

Nexela opened this issue May 21, 2017 · 2 comments
Labels
enhancement help wanted
Milestone
Future Direction

Comments

@Nexela
Copy link
Collaborator

Nexela commented May 21, 2017

Trains now have unique IDs on_train_created (and other train events) stdlib/trains should be changed yet again to use these IDs
@Choumiko
Copy link
Contributor

Choumiko commented May 21, 2017 •
edited
Loading

on_train_created is currently bugged until the next release: https://forums.factorio.com/viewtopic.php?f=30&t=47958

Kind of waiting until 15.13 to start rewriting my train tackers. Guess this would be a good point to switch them all over to 1 implementation, currently i have 3 (SmartTrains, FatController and FARL :D)

@Afforess Afforess added this to the 1.0 Stdlib Release milestone May 22, 2017
Choumiko added a commit to Choumiko/Factorio-Stdlib that referenced this issue May 26, 2017
@Choumiko
changed Trains module to use on_train_created event Afforess#84
0eff3f3 
Currently this is breaking backwards compatibility
@Afforess
Copy link
Owner

Afforess commented Jun 7, 2017

Unless someone volunteers for this, I will push this off to the next release, after 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
Future Direction
Development

No branches or pull requests
3 participants
@Afforess @Choumiko @Nexela