Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor authentication_spec.rb to use shared examples #73

Open
aonomike opened this issue May 6, 2020 · 0 comments
Open

Refactor authentication_spec.rb to use shared examples #73

aonomike opened this issue May 6, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@aonomike
Copy link
Collaborator

aonomike commented May 6, 2020 •
edited
Loading

Given this comment from a PR review we can use a shared example to make the tests better

Expected Behavior

All tests still pass after the refactor

Current Behavior

All tests are passing but can be improved

Possible Solution

Use shared examples
@aonomike aonomike changed the title Refactor authentication_spec.rb to use shared examples Refactor authentication_spec.rb to use shared examples May 6, 2020
@aonomike aonomike added enhancement New feature or request help wanted Extra attention is needed labels May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aonomike