From 2e41b106462b30f4b0e908abedb8d174b038eee8 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Wed, 11 Sep 2024 08:45:44 -0700 Subject: [PATCH 01/10] chore: update type-coverage --- packages/async-flow/package.json | 2 +- packages/boot/package.json | 2 +- packages/cosmic-swingset/package.json | 2 +- packages/internal/package.json | 2 +- packages/orchestration/package.json | 2 +- packages/solo/package.json | 2 +- packages/swing-store/package.json | 2 +- packages/zoe/package.json | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/async-flow/package.json b/packages/async-flow/package.json index 5ea43fd7cad..303035f600b 100644 --- a/packages/async-flow/package.json +++ b/packages/async-flow/package.json @@ -61,6 +61,6 @@ "workerThreads": false }, "typeCoverage": { - "atLeast": 77.1 + "atLeast": 77.29 } } diff --git a/packages/boot/package.json b/packages/boot/package.json index 8be443aa505..647fb2a0160 100644 --- a/packages/boot/package.json +++ b/packages/boot/package.json @@ -90,6 +90,6 @@ "workerThreads": false }, "typeCoverage": { - "atLeast": 90.03 + "atLeast": 90.31 } } diff --git a/packages/cosmic-swingset/package.json b/packages/cosmic-swingset/package.json index 8622cf27efa..fa2309d970a 100644 --- a/packages/cosmic-swingset/package.json +++ b/packages/cosmic-swingset/package.json @@ -69,6 +69,6 @@ "timeout": "20m" }, "typeCoverage": { - "atLeast": 80.53 + "atLeast": 80.55 } } diff --git a/packages/internal/package.json b/packages/internal/package.json index 63018dc4fea..f6ba5f69719 100755 --- a/packages/internal/package.json +++ b/packages/internal/package.json @@ -57,6 +57,6 @@ "access": "public" }, "typeCoverage": { - "atLeast": 93.32 + "atLeast": 93.41 } } diff --git a/packages/orchestration/package.json b/packages/orchestration/package.json index 7c53a4a711e..a20ea74ed6b 100644 --- a/packages/orchestration/package.json +++ b/packages/orchestration/package.json @@ -92,6 +92,6 @@ "access": "public" }, "typeCoverage": { - "atLeast": 97.57 + "atLeast": 97.6 } } diff --git a/packages/solo/package.json b/packages/solo/package.json index f55de934e9e..9d84a6d5e6e 100644 --- a/packages/solo/package.json +++ b/packages/solo/package.json @@ -77,6 +77,6 @@ "workerThreads": false }, "typeCoverage": { - "atLeast": 73.4 + "atLeast": 73.55 } } diff --git a/packages/swing-store/package.json b/packages/swing-store/package.json index 5a6dae3b5bd..7e068e46042 100644 --- a/packages/swing-store/package.json +++ b/packages/swing-store/package.json @@ -49,6 +49,6 @@ "timeout": "2m" }, "typeCoverage": { - "atLeast": 78.77 + "atLeast": 79.02 } } diff --git a/packages/zoe/package.json b/packages/zoe/package.json index fd67cdeea85..bb227dc44c7 100644 --- a/packages/zoe/package.json +++ b/packages/zoe/package.json @@ -141,6 +141,6 @@ "access": "public" }, "typeCoverage": { - "atLeast": 85.02 + "atLeast": 85.01 } } From ffff8f25cd553bcdd9d322e164ec5e4b7e27ce67 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Wed, 11 Sep 2024 08:39:43 -0700 Subject: [PATCH 02/10] chore(deps): bump typescript to 5.6 release --- package.json | 4 ++-- packages/cosmic-proto/package.json | 2 +- yarn.lock | 22 +++++++++++++++++----- 3 files changed, 20 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index 021de737385..6631745c99a 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "@endo/eslint-plugin": "^2.2.1", "@jessie.js/eslint-plugin": "^0.4.1", "@types/express": "^4.17.17", - "@types/node": "^18.19.24", + "@types/node": "^22.0.0", "ava": "^5.3.0", "c8": "^9.1.0", "conventional-changelog-conventionalcommits": "^4.6.0", @@ -34,7 +34,7 @@ "type-coverage": "^2.27.1", "typedoc": "^0.26.7", "typedoc-plugin-markdown": "^4.2.1", - "typescript": "^5.5.3", + "typescript": "^5.6.2", "typescript-eslint": "^7.15.0" }, "resolutions": { diff --git a/packages/cosmic-proto/package.json b/packages/cosmic-proto/package.json index 1b82434a185..1cb06d9f84f 100644 --- a/packages/cosmic-proto/package.json +++ b/packages/cosmic-proto/package.json @@ -151,7 +151,7 @@ "rimraf": "^5.0.0", "tsd": "^0.31.1", "tsimp": "^2.0.11", - "typescript": "^5.5.3" + "typescript": "~5.6.2" }, "dependencies": { "@endo/base64": "^1.0.7", diff --git a/yarn.lock b/yarn.lock index ca29a62266d..bcf533c01d3 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3609,13 +3609,20 @@ dependencies: "@types/node" "*" -"@types/node@*", "@types/node@>=13.7.0", "@types/node@^18.19.24": +"@types/node@*", "@types/node@>=13.7.0": version "18.19.24" resolved "https://registry.yarnpkg.com/@types/node/-/node-18.19.24.tgz#707d8a4907e55901466e60e8f7a62bc6197ace95" integrity sha512-eghAz3gnbQbvnHqB+mgB2ZR3aH6RhdEmHGS48BnV75KceQPHqabkxKI0BbUSsqhqy2Ddhc2xD/VAR9ySZd57Lw== dependencies: undici-types "~5.26.4" +"@types/node@^22.0.0": + version "22.0.0" + resolved "https://registry.yarnpkg.com/@types/node/-/node-22.0.0.tgz#04862a2a71e62264426083abe1e27e87cac05a30" + integrity sha512-VT7KSYudcPOzP5Q0wfbowyNLaVR8QWUdw+088uFWwfvpY6uCWaXpqV6ieLAu9WBcnTa7H4Z5RLK8I5t2FuOcqw== + dependencies: + undici-types "~6.11.1" + "@types/normalize-package-data@^2.4.0": version "2.4.0" resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz#e486d0d97396d79beedd0a6e33f4534ff6b4973e" @@ -11669,10 +11676,10 @@ typescript-eslint@^7.15.0, typescript-eslint@^7.3.1: resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.5.tgz#095979f9bcc0d09da324d58d03ce8f8374cbe65a" integrity sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g== -typescript@^5.5.3: - version "5.5.3" - resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.3.tgz#e1b0a3c394190838a0b168e771b0ad56a0af0faa" - integrity sha512-/hreyEujaB0w76zKo6717l3L0o/qEUtRgdvUBvlkhoWeOVMjMuHNHk0BRBzikzuGDqNmPQbg5ifMEqsHLiIUcQ== +typescript@^5.6.2, typescript@~5.6.2: + version "5.6.2" + resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.6.2.tgz#d1de67b6bef77c41823f822df8f0b3bcff60a5a0" + integrity sha512-NW8ByodCSNCwZeghjN3o+JX5OFH0Ojg6sadjEKY4huZ52TqbJTJnDo5+Tw98lSy63NZvi4n+ez5m2u5d4PkZyw== typescript@~5.6.1-rc: version "5.6.1-rc" @@ -11704,6 +11711,11 @@ undici-types@~5.26.4: resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.26.5.tgz#bcd539893d00b56e964fd2657a4866b221a65617" integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA== +undici-types@~6.11.1: + version "6.11.1" + resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-6.11.1.tgz#432ea6e8efd54a48569705a699e62d8f4981b197" + integrity sha512-mIDEX2ek50x0OlRgxryxsenE5XaQD4on5U2inY7RApK3SOJpofyw7uW2AyfMKkhAxXIceo2DeWGVGwyvng1GNQ== + unicode-canonical-property-names-ecmascript@^2.0.0: version "2.0.0" resolved "https://registry.yarnpkg.com/unicode-canonical-property-names-ecmascript/-/unicode-canonical-property-names-ecmascript-2.0.0.tgz#301acdc525631670d39f6146e0e77ff6bbdebddc" From c180b9bc42766f7ba92936f99b21b9d377c10959 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Mon, 29 Jul 2024 07:07:26 -0400 Subject: [PATCH 03/10] chore(types): KernelKeeper --- packages/SwingSet/src/kernel/deviceTranslator.js | 2 +- packages/SwingSet/src/kernel/gc-actions.js | 5 ++--- packages/SwingSet/src/kernel/kernel.js | 2 +- packages/SwingSet/src/kernel/state/kernelKeeper.js | 4 ++++ packages/SwingSet/src/types-external.js | 2 +- packages/SwingSet/test/gc-actions.test.js | 3 +++ 6 files changed, 12 insertions(+), 6 deletions(-) diff --git a/packages/SwingSet/src/kernel/deviceTranslator.js b/packages/SwingSet/src/kernel/deviceTranslator.js index 229d27512aa..6152e4b4943 100644 --- a/packages/SwingSet/src/kernel/deviceTranslator.js +++ b/packages/SwingSet/src/kernel/deviceTranslator.js @@ -69,7 +69,7 @@ function makeDRTranslator(deviceID, kernelKeeper) { * * @param {string} deviceID * @param {string} deviceName - * @param {*} kernelKeeper + * @param {KernelKeeper} kernelKeeper * @returns {(dsc: DeviceSyscallObject) => KernelSyscallObject} */ export function makeDSTranslator(deviceID, deviceName, kernelKeeper) { diff --git a/packages/SwingSet/src/kernel/gc-actions.js b/packages/SwingSet/src/kernel/gc-actions.js index ca575525169..ccc378fbbe9 100644 --- a/packages/SwingSet/src/kernel/gc-actions.js +++ b/packages/SwingSet/src/kernel/gc-actions.js @@ -45,7 +45,7 @@ function parseAction(s) { } /** - * @param {*} kernelKeeper + * @param {KernelKeeper} kernelKeeper * @returns {import('../types-internal.js').RunQueueEvent | undefined} */ export function processGCActionSet(kernelKeeper) { @@ -86,10 +86,9 @@ export function processGCActionSet(kernelKeeper) { const hasCList = vatKeeper.hasCListEntry(kref); const isReachable = hasCList ? vatKeeper.getReachableFlag(kref) : undefined; const exists = kernelKeeper.kernelObjectExists(kref); - // @ts-expect-error xxx const { reachable, recognizable } = exists ? kernelKeeper.getObjectRefCount(kref) - : {}; + : { reachable: 0, recognizable: 0 }; if (type === 'dropExport') { if (!exists) return false; // already, shouldn't happen diff --git a/packages/SwingSet/src/kernel/kernel.js b/packages/SwingSet/src/kernel/kernel.js index 4ad68f7ed7c..6ef6a4353db 100644 --- a/packages/SwingSet/src/kernel/kernel.js +++ b/packages/SwingSet/src/kernel/kernel.js @@ -56,7 +56,7 @@ function abbreviateReplacer(_, arg) { /** * Provide the kref of a vat's root object, as if it had been exported. * - * @param {*} kernelKeeper Kernel keeper managing persistent kernel state. + * @param {KernelKeeper} kernelKeeper Kernel keeper managing persistent kernel state. * @param {string} vatID Vat ID of the vat whose root kref is sought. * * @returns {string} the kref of the root object of the given vat. diff --git a/packages/SwingSet/src/kernel/state/kernelKeeper.js b/packages/SwingSet/src/kernel/state/kernelKeeper.js index 11d3180400c..1d456160bf8 100644 --- a/packages/SwingSet/src/kernel/state/kernelKeeper.js +++ b/packages/SwingSet/src/kernel/state/kernelKeeper.js @@ -178,6 +178,7 @@ export const CURRENT_SCHEMA_VERSION = 2; // * change `version` to `'2'` // * add `vats.terminated` with `[]` as initial value +/** @type {(s: string) => string[]} s */ export function commaSplit(s) { if (s === '') { return []; @@ -804,6 +805,7 @@ export default function makeKernelKeeper( p.decider = undefined; } p.policy = kvStore.get(`${kernelSlot}.policy`) || 'ignore'; + // @ts-expect-error get() may fail p.subscribers = commaSplit(kvStore.get(`${kernelSlot}.subscribers`)); p.queue = Array.from( getPrefixedValues(kvStore, `${kernelSlot}.queue.`), @@ -815,6 +817,7 @@ export default function makeKernelKeeper( p.refCount = Number(kvStore.get(`${kernelSlot}.refCount`)); p.data = { body: kvStore.get(`${kernelSlot}.data.body`), + // @ts-expect-error get() may fail slots: commaSplit(kvStore.get(`${kernelSlot}.data.slots`)), }; for (const s of p.data.slots) { @@ -1981,3 +1984,4 @@ export default function makeKernelKeeper( dump, }); } +/** @typedef {ReturnType} KernelKeeper */ diff --git a/packages/SwingSet/src/types-external.js b/packages/SwingSet/src/types-external.js index a90c4ab2b7a..e04f1313e6a 100644 --- a/packages/SwingSet/src/types-external.js +++ b/packages/SwingSet/src/types-external.js @@ -124,7 +124,7 @@ export {}; * * @typedef { { transcriptCount: number } } VatStats * @typedef { ReturnType } VatKeeper - * @typedef { ReturnType } KernelKeeper + * @typedef { import('./kernel/state/kernelKeeper.js').KernelKeeper } KernelKeeper * @typedef { Awaited> } XSnap * @typedef { (dr: VatDeliveryResult) => void } SlogFinishDelivery * @typedef { (ksr: KernelSyscallResult, vsr: VatSyscallResult) => void } SlogFinishSyscall diff --git a/packages/SwingSet/test/gc-actions.test.js b/packages/SwingSet/test/gc-actions.test.js index cfb16f8ce56..14030712810 100644 --- a/packages/SwingSet/test/gc-actions.test.js +++ b/packages/SwingSet/test/gc-actions.test.js @@ -13,6 +13,7 @@ test('gc actions', t => { } const clistState = { v1: { ko1: {}, ko2: {} }, v2: { ko2: {} } }; + /** @type {KernelKeeper} */ const kernelKeeper = { getGCActions() { return new Set(actions); @@ -28,7 +29,9 @@ test('gc actions', t => { const [reachable, recognizable] = rc[kref]; return { reachable, recognizable }; }, + // @ts-expect-error mock emitCrankHashes() {}, + // @ts-expect-error mock provideVatKeeper(vatID) { return { hasCListEntry(kref) { From 3779833adadfbbe4f407941c9727c549c32be0a9 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Thu, 5 Sep 2024 10:54:46 -0700 Subject: [PATCH 04/10] chore(types): import each name the `import *` is no longer working for some reason --- packages/SwingSet/src/kernel/kernel.js | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/packages/SwingSet/src/kernel/kernel.js b/packages/SwingSet/src/kernel/kernel.js index 6ef6a4353db..b6e11dbd714 100644 --- a/packages/SwingSet/src/kernel/kernel.js +++ b/packages/SwingSet/src/kernel/kernel.js @@ -39,8 +39,10 @@ import { makeDeviceTranslators } from './deviceTranslator.js'; import { notifyTermination } from './notifyTermination.js'; import { makeVatAdminHooks } from './vat-admin-hooks.js'; -/** @import * as liveslots from '@agoric/swingset-liveslots' */ -/** @import {PolicyInputCleanupCounts} from '../types-external.js' */ +/** + * @import {MeterConsumption, VatDeliveryObject, VatDeliveryResult, VatSyscallObject, VatSyscallResult} from '@agoric/swingset-liveslots'; + * @import {PolicyInputCleanupCounts} from '../types-external.js'; + */ function abbreviateReplacer(_, arg) { if (typeof arg === 'bigint') { @@ -380,7 +382,6 @@ export default function buildKernel( /** * - * @typedef { import('@agoric/swingset-liveslots').MeterConsumption } MeterConsumption * @typedef { import('../types-internal.js').MeterID } MeterID * @typedef { import('../types-internal.js').Dirt } Dirt * @@ -416,7 +417,7 @@ export default function buildKernel( * * @param {VatID} vatID * @param {KernelDeliveryObject} kd - * @param {liveslots.VatDeliveryObject} vd + * @param {VatDeliveryObject} vd */ async function deliverAndLogToVat(vatID, kd, vd) { vatRequestedTermination = undefined; @@ -426,7 +427,7 @@ export default function buildKernel( const vs = kernelSlog.provideVatSlogger(vatID).vatSlog; await null; try { - /** @type { liveslots.VatDeliveryResult } */ + /** @type { VatDeliveryResult } */ const deliveryResult = await vatWarehouse.deliverToVat(vatID, kd, vd, vs); insistVatDeliveryResult(deliveryResult); // const [ ok, problem, usage ] = deliveryResult; @@ -1542,8 +1543,8 @@ export default function buildKernel( // not /** * - * @param {liveslots.VatSyscallObject} vatSyscallObject - * @returns {liveslots.VatSyscallResult} + * @param {VatSyscallObject} vatSyscallObject + * @returns {VatSyscallResult} */ function vatSyscallHandler(vatSyscallObject) { if (!vatWarehouse.lookup(vatID)) { @@ -1558,7 +1559,7 @@ export default function buildKernel( let ksc; /** @type { KernelSyscallResult } */ let kres = harden(['error', 'incomplete']); - /** @type { liveslots.VatSyscallResult } */ + /** @type { VatSyscallResult } */ let vres = harden(['error', 'incomplete']); try { From cf204c59df9b32c958d02df16ee7b6acee960e62 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Thu, 5 Sep 2024 11:11:39 -0700 Subject: [PATCH 05/10] chore(types): update suppressions --- packages/SwingSet/misc-tools/replay-transcript.js | 9 +++++++-- packages/smart-wallet/test/supports.js | 1 - 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/SwingSet/misc-tools/replay-transcript.js b/packages/SwingSet/misc-tools/replay-transcript.js index a5bb7a127c6..1dfdc5c1322 100644 --- a/packages/SwingSet/misc-tools/replay-transcript.js +++ b/packages/SwingSet/misc-tools/replay-transcript.js @@ -30,6 +30,10 @@ import { makeLocalVatManagerFactory } from '../src/kernel/vat-loader/manager-loc import { makeSyscallSimulator } from '../src/kernel/vat-warehouse.js'; import { makeDummyMeterControl } from '../src/kernel/dummyMeterControl.js'; +/** + * @import {SnapStore} from '@agoric/swing-store'; + */ + const finished = promisify(finishedCallback); // TODO: switch to full yargs for documenting output @@ -213,7 +217,8 @@ async function replay(transcriptFile) { let cleanupSnapStore; if (argv.useCustomSnapStore) { - snapStore = /** @type {SnapStore} */ ({ + snapStore = { + // @ts-expect-error missing methods and saveSnapshot return is missing field of SnapshotResult async saveSnapshot(_vatID, snapPos, snapshotStream) { const snapFile = `${vatID}-${snapPos}-${ saveSnapshotID || 'unknown' @@ -238,7 +243,7 @@ async function replay(transcriptFile) { const snapFile = `${vatID}-${loadSnapshotID}.xss`; yield* fs.createReadStream(snapFile); }, - }); + }; } else { const tmpDb = tmpDirSync({ prefix: `ag-replay-${transcriptFile}`, diff --git a/packages/smart-wallet/test/supports.js b/packages/smart-wallet/test/supports.js index c02c11b3b5b..45628382da1 100644 --- a/packages/smart-wallet/test/supports.js +++ b/packages/smart-wallet/test/supports.js @@ -63,7 +63,6 @@ export const subscriptionKey = subscription => { /** @returns {import('@agoric/vats').BridgeManager} */ const makeFakeBridgeManager = () => - // @ts-expect-error XXX generics puzzle: could be instantiated with a different subtype of constraint Far('fakeBridgeManager', { register(bridgeId, handler) { return Far('scopedBridgeManager', { From 7dbdda1a19befefafb755cbd7fae82ec1f066390 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Thu, 5 Sep 2024 11:10:34 -0700 Subject: [PATCH 06/10] chore: define asyncDispose in synchronizedTee --- packages/internal/src/utils.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/internal/src/utils.js b/packages/internal/src/utils.js index 0733fbf2deb..bd69cdfabb9 100644 --- a/packages/internal/src/utils.js +++ b/packages/internal/src/utils.js @@ -401,6 +401,10 @@ export const synchronizedTee = (sourceStream, readerCount) => { [Symbol.asyncIterator]() { return reader; }, + // eslint-disable-next-line no-restricted-globals + async [Symbol.asyncDispose]() { + await reader.return(); + }, }); return reader; }); From d0ef7994cb70eb1ffd7e4a3fa5e9adffef319ab1 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Thu, 5 Sep 2024 11:22:38 -0700 Subject: [PATCH 07/10] ci(types): enable noUncheckedSideEffectImports --- packages/xsnap/test/leakiness.mjs | 1 + tsconfig.json | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/xsnap/test/leakiness.mjs b/packages/xsnap/test/leakiness.mjs index 96534df237b..5b588268387 100644 --- a/packages/xsnap/test/leakiness.mjs +++ b/packages/xsnap/test/leakiness.mjs @@ -4,6 +4,7 @@ // See below for usage detail about the latter. import 'ses'; import '@endo/eventual-send/shim.js'; +// @ts-expect-error Cannot find module import 'data:text/javascript,try { lockdown(); } catch (_err) {}'; import * as proc from 'child_process'; diff --git a/tsconfig.json b/tsconfig.json index 247fab83052..f5ff8dc3a0d 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -13,6 +13,7 @@ "downlevelIteration": true, "strictNullChecks": true, "noImplicitThis": true, + "noUncheckedSideEffectImports": true, "noEmit": true }, "include": [ From 9fe7b8b6b70275a732cdd00d7b4f043339c447be Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Thu, 5 Sep 2024 11:44:03 -0700 Subject: [PATCH 08/10] build: clean .tsbuildinfo --- packages/ERTP/package.json | 2 +- packages/async-flow/package.json | 2 +- packages/base-zone/package.json | 2 +- packages/builders/package.json | 2 +- packages/casting/package.json | 2 +- packages/governance/package.json | 2 +- packages/inter-protocol/package.json | 2 +- packages/internal/package.json | 2 +- packages/network/package.json | 2 +- packages/notifier/package.json | 2 +- packages/orchestration/package.json | 2 +- packages/smart-wallet/package.json | 2 +- packages/vats/package.json | 2 +- packages/vow/package.json | 2 +- packages/zoe/package.json | 2 +- packages/zone/package.json | 2 +- 16 files changed, 16 insertions(+), 16 deletions(-) diff --git a/packages/ERTP/package.json b/packages/ERTP/package.json index 35ea9f1d420..ca4471e6c7e 100644 --- a/packages/ERTP/package.json +++ b/packages/ERTP/package.json @@ -10,7 +10,7 @@ "scripts": { "build": "exit 0", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava", "test:xs": "yarn test:xs-unit && yarn test:xs-worker", diff --git a/packages/async-flow/package.json b/packages/async-flow/package.json index 303035f600b..e7fadad8be8 100644 --- a/packages/async-flow/package.json +++ b/packages/async-flow/package.json @@ -8,7 +8,7 @@ "scripts": { "build": "exit 0", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js", "test:xs": "exit 0", diff --git a/packages/base-zone/package.json b/packages/base-zone/package.json index fd8dab07420..5ab76eac728 100644 --- a/packages/base-zone/package.json +++ b/packages/base-zone/package.json @@ -8,7 +8,7 @@ "scripts": { "build": "exit 0", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js", "test:xs": "exit 0", diff --git a/packages/builders/package.json b/packages/builders/package.json index 7bcc10454e3..a444755dc70 100644 --- a/packages/builders/package.json +++ b/packages/builders/package.json @@ -11,7 +11,7 @@ "build:restart-vats-proposal": "echo This command has been deprecated. Please run this instead: agoric run scripts/vats/restart-vats.js", "build:zcf-proposal": "echo This command has been deprecated. Please run this instead: agoric run scripts/vats/replace-zoe.js", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:xs": "exit 0", "lint-fix": "yarn lint:eslint --fix", diff --git a/packages/casting/package.json b/packages/casting/package.json index 018c146c0ab..6edf3fb70bb 100644 --- a/packages/casting/package.json +++ b/packages/casting/package.json @@ -8,7 +8,7 @@ "scripts": { "build": "exit 0", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "demo": "node -e 'import(\"./test/fake-rpc-server.js\").then(ns => ns.develop())'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js", diff --git a/packages/governance/package.json b/packages/governance/package.json index 240f64cfc82..e7cc46d9e4b 100644 --- a/packages/governance/package.json +++ b/packages/governance/package.json @@ -11,7 +11,7 @@ "build": "yarn build:bundles", "build:bundles": "node ./scripts/build-bundles.js", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js", "test:xs": "exit 0", diff --git a/packages/inter-protocol/package.json b/packages/inter-protocol/package.json index 334690cbdf0..59f4140da00 100644 --- a/packages/inter-protocol/package.json +++ b/packages/inter-protocol/package.json @@ -11,7 +11,7 @@ "build": "yarn build:bundles", "build:bundles": "node ./scripts/build-bundles.js", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js", "test:xs": "exit 0", diff --git a/packages/internal/package.json b/packages/internal/package.json index f6ba5f69719..4d036d060f2 100755 --- a/packages/internal/package.json +++ b/packages/internal/package.json @@ -10,7 +10,7 @@ "scripts": { "build": "exit 0", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:nyc": "exit 0", "test:xs": "exit 0", diff --git a/packages/network/package.json b/packages/network/package.json index b3f379269c3..c1e3fefacdd 100644 --- a/packages/network/package.json +++ b/packages/network/package.json @@ -8,7 +8,7 @@ "scripts": { "build": "exit 0", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava", "test:xs": "exit 0", diff --git a/packages/notifier/package.json b/packages/notifier/package.json index f7d90b492d6..425c3dd17af 100644 --- a/packages/notifier/package.json +++ b/packages/notifier/package.json @@ -10,7 +10,7 @@ "scripts": { "build": "exit 0", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js", "test:xs": "exit 0", diff --git a/packages/orchestration/package.json b/packages/orchestration/package.json index a20ea74ed6b..96fdcad0e17 100644 --- a/packages/orchestration/package.json +++ b/packages/orchestration/package.json @@ -12,7 +12,7 @@ "build": "exit 0", "codegen": "scripts/fetch-chain-info.ts", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js", "test:xs": "exit 0", diff --git a/packages/smart-wallet/package.json b/packages/smart-wallet/package.json index 3952c78c568..69cbaac80db 100644 --- a/packages/smart-wallet/package.json +++ b/packages/smart-wallet/package.json @@ -7,7 +7,7 @@ "build": "yarn build:bundles", "build:bundles": "node ./scripts/build-bundles.js", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:xs": "exit 0", "lint": "run-s --continue-on-error lint:*", diff --git a/packages/vats/package.json b/packages/vats/package.json index 6a93f60a68f..a00da337223 100644 --- a/packages/vats/package.json +++ b/packages/vats/package.json @@ -9,7 +9,7 @@ "build": "yarn build:bundles", "build:bundles": "node scripts/build-bundles.js", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava", "test:xs": "exit 0", diff --git a/packages/vow/package.json b/packages/vow/package.json index b938dbcd1fc..bbc28dd9ba1 100755 --- a/packages/vow/package.json +++ b/packages/vow/package.json @@ -10,7 +10,7 @@ "scripts": { "build": "exit 0", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:nyc": "exit 0", "test:xs": "exit 0", diff --git a/packages/zoe/package.json b/packages/zoe/package.json index bb227dc44c7..0f1c34fc306 100644 --- a/packages/zoe/package.json +++ b/packages/zoe/package.json @@ -11,7 +11,7 @@ "build": "yarn build:bundles", "build:bundles": "node scripts/build-bundles.js", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava --verbose", "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js", "test:unit": "ava 'test/unitTests' -T 1m --verbose", diff --git a/packages/zone/package.json b/packages/zone/package.json index b85d4f3d272..29bfa7d5445 100644 --- a/packages/zone/package.json +++ b/packages/zone/package.json @@ -8,7 +8,7 @@ "scripts": { "build": "exit 0", "prepack": "tsc --build tsconfig.build.json", - "postpack": "git clean -f '*.d.ts*'", + "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js", "test:xs": "exit 0", From 5f25c50c304f4411389e4cf5a0a068ccae8854d6 Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Wed, 11 Sep 2024 08:47:49 -0700 Subject: [PATCH 09/10] chore: update type-coverage --- packages/SwingSet/package.json | 2 +- packages/internal/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/SwingSet/package.json b/packages/SwingSet/package.json index b5aa9ad3012..d9b784f255a 100644 --- a/packages/SwingSet/package.json +++ b/packages/SwingSet/package.json @@ -101,6 +101,6 @@ "access": "public" }, "typeCoverage": { - "atLeast": 75.7 + "atLeast": 75.81 } } diff --git a/packages/internal/package.json b/packages/internal/package.json index 4d036d060f2..ad31590ee43 100755 --- a/packages/internal/package.json +++ b/packages/internal/package.json @@ -57,6 +57,6 @@ "access": "public" }, "typeCoverage": { - "atLeast": 93.41 + "atLeast": 93.42 } } From 37e43c6fb68288ef5b0ee3cc0b785a2f2466ecac Mon Sep 17 00:00:00 2001 From: Turadg Aleahmad Date: Wed, 11 Sep 2024 08:52:50 -0700 Subject: [PATCH 10/10] build: rm unused test:nyc, test:c8 --- packages/vat-data/package.json | 1 - packages/vow/package.json | 1 - 2 files changed, 2 deletions(-) diff --git a/packages/vat-data/package.json b/packages/vat-data/package.json index 114f62942d9..52a7ab0dab4 100644 --- a/packages/vat-data/package.json +++ b/packages/vat-data/package.json @@ -8,7 +8,6 @@ "scripts": { "build": "exit 0", "test": "ava", - "test:c8": "exit 0", "test:xs": "exit 0", "lint-fix": "yarn lint:eslint --fix", "lint": "run-s --continue-on-error lint:*", diff --git a/packages/vow/package.json b/packages/vow/package.json index bbc28dd9ba1..7acbfa1b4dc 100755 --- a/packages/vow/package.json +++ b/packages/vow/package.json @@ -12,7 +12,6 @@ "prepack": "tsc --build tsconfig.build.json", "postpack": "git clean -f '*.d.ts*' '*.tsbuildinfo'", "test": "ava", - "test:nyc": "exit 0", "test:xs": "exit 0", "lint-fix": "yarn lint:eslint --fix", "lint": "run-s --continue-on-error lint:*",