Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate core evals for auction, vaults, and price feeds #10020

Closed
Chris-Hibbert opened this issue Sep 3, 2024 · 3 comments
Closed

integrate core evals for auction, vaults, and price feeds #10020

Chris-Hibbert opened this issue Sep 3, 2024 · 3 comments
Assignees
@Chris-Hibbert

Comments

@Chris-Hibbert
Copy link
Contributor

change core-eval for priceFeed, vaults, auctions

later ones need to be coordinated with earlier ones using promises

Test Plan

include a3p test
@Chris-Hibbert Chris-Hibbert self-assigned this Sep 3, 2024
@Chris-Hibbert Chris-Hibbert mentioned this issue Sep 3, 2024
Closed
@Chris-Hibbert
Copy link
Contributor Author

overtaken by #10074

@dckc
Copy link
Member

dckc commented Sep 19, 2024

Closing this as completed looks misleading.

I'm not sure what it means for an issue to be overtaken by an open PR.

I'm inclined to use this to track the stuff I handed over in #9827 .

@dckc dckc reopened this Sep 19, 2024
@dckc
Copy link
Member

dckc commented Oct 21, 2024

fixed in #10074

@dckc dckc closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dckc @Chris-Hibbert