Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptance test of bids surviving upgrades #10111

Open
turadg opened this issue Sep 18, 2024 · 1 comment
Open

acceptance test of bids surviving upgrades #10111

turadg opened this issue Sep 18, 2024 · 1 comment
Labels

Comments

@turadg
Copy link
Member

turadg commented Sep 18, 2024

What is the Problem Being Solved?

We have some tests of bids surviving restarts but we don't have any chain integration tests of it.

Today we encountered the following error while qualifying upgrade-17 with Mainfork,

SwingSet: xsnap: v10: UnhandledPromiseRejectionWarning: { incarnationNumber: 3, name: 'vatUpgraded', upgradeMessage: 'vat upgraded' }

and it took some debugging to identify it as the watcher for outstanding bids. If the A3P tests had that in their logs it would be more apparent as part of the expected behavior. (Better error handling may be in order but that requires upgrading vat-bridge which is way off.)

Description of the Design

Place a bid in some "use" layer of some early proposal.

In z:acceptance make sure it's still live.

Perhaps also adjust prices so that the bid is fulfilled and confirm payouts.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@turadg turadg added enhancement New feature or request test and removed enhancement New feature or request labels Sep 18, 2024
@mhofman
Copy link
Member

mhofman commented Sep 18, 2024

Better error handling may be in order but that requires upgrading vat-bridge which is way off

Having the smart wallet use a vow as result of the bridge handler would likely be the best approach. Then we have more plumbing in the bridge vat to bubble that up to cosmic-swingset and vstorage. See #8441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants